Bug #13790
closedrubyspec.org domain seems to be expired
Description
Summary¶
Ruby codebase has http links to rubyspec.org, but the domain is likely owned by different person, and the web page shows completely different stuff.
Should we replace these URLs, so that we don't accidentally lead people to that site, and optionally we don't raise the pagerank of that site?
https://github.com/ruby/ruby/search?utf8=%E2%9C%93&q=rubyspec.org&type=
Background and problem details¶
Ruby included rubyspec couple years ago. There used to be http://www.rubyspec.org which hosted actual rubyspec info that we imagine.
I'm not sure when it happened, but the rubyspec.org domain seems to be expired and is currently owned by somebody different, according to how it looks like right now.
https://github.com/ruby/ruby/search?p=1&q=rubyspec.org&type=&utf8=%E2%9C%93
spec/rubyspec/library/net/http/http/send_request_spec.rb: This test sends an HTTP request to www.rubyspec.org just as an example. I'm surprised this test has been passing. Of course there won't be any guarantees that this passes in the future.
spec/mspec/mspec.gemspec: very problematic
spec/rubyspec/core/struct/inspect_spec.rb: (yay my name is there!) that issue is missing of course
Proposed solution¶
spec/rubyspec/library/net/http/http/send_request_spec.rb: Should we keep it? If we do, let's find another example
spec/mspec/mspec.gemspec: replace it with this new url http://ruby.github.io/rubyspec.github.io/
spec/rubyspec/core/struct/inspect_spec.rb: refer webarchive url or just note that the url does not exist in the comment
Updated by hsbt (Hiroshi SHIBATA) over 6 years ago
- Assignee set to Eregon (Benoit Daloze)
Updated by esparta (Espartaco Palma) over 6 years ago
If we need to send real request to internet I suggest to use HTTPBin.org
Also, with HTTPBin we can un-comment all the other methods currently not tested (PUT, POST, DELETE, etc).
HTH.
Espartaco Palma
ujihisa (Tatsuhiro Ujihisa) wrote:
Summary¶
Ruby codebase has http links to rubyspec.org, but the domain is likely owned by different person, and the web page shows completely different stuff.
Should we replace these URLs, so that we don't accidentally lead people to that site, and optionally we don't raise the pagerank of that site?
https://github.com/ruby/ruby/search?utf8=%E2%9C%93&q=rubyspec.org&type=Background and problem details¶
Ruby included rubyspec couple years ago. There used to be http://www.rubyspec.org which hosted actual rubyspec info that we imagine.
I'm not sure when it happened, but the rubyspec.org domain seems to be expired and is currently owned by somebody different, according to how it looks like right now.https://github.com/ruby/ruby/search?p=1&q=rubyspec.org&type=&utf8=%E2%9C%93
spec/rubyspec/library/net/http/http/send_request_spec.rb: This test sends an HTTP request to www.rubyspec.org just as an example. I'm surprised this test has been passing. Of course there won't be any guarantees that this passes in the future.
spec/mspec/mspec.gemspec: very problematic
spec/rubyspec/core/struct/inspect_spec.rb: (yay my name is there!) that issue is missing of course
Proposed solution¶
spec/rubyspec/library/net/http/http/send_request_spec.rb: Should we keep it? If we do, let's find another example
spec/mspec/mspec.gemspec: replace it with this new url http://ruby.github.io/rubyspec.github.io/
spec/rubyspec/core/struct/inspect_spec.rb: refer webarchive url or just note that the url does not exist in the comment
Updated by Eregon (Benoit Daloze) over 6 years ago
Thanks for the report, I'll take a look.
http://ruby.github.io/rubyspec.github.io/ has similar contents to what rubyspec.org hosted but it's not really maintained.
I think we should replace the links with a link to https://github.com/ruby/spec/ or fix the tests to use a more reliable source.
Updated by Eregon (Benoit Daloze) over 6 years ago
Re spec/mspec/mspec.gemspec, actually https://github.com/ruby/mspec is no longer distributed as a gem, the file has been removed.
I'll do the usual ruby/spec and ruby/mspec synchronization so this one will be fixed by it.
Updated by Eregon (Benoit Daloze) over 6 years ago
In spec/rubyspec/library/net/http/http/send_request_spec.rb, it's only the referer value in the headers.
The request are sent to a local WEBrick server.
Updated by Eregon (Benoit Daloze) over 6 years ago
- Status changed from Open to Closed
This is fixed as of r59911
There is still one instance in 1.9.3's ChangeLog but it seems harmless.
$ git grep rubyspec.org
doc/ChangeLog-1.9.3: http://rubyspec.org/issues/show/161
Updated by ujihisa (Tatsuhiro Ujihisa) over 6 years ago
Yay! 👏