Project

General

Profile

Bug #14010

RubyVM logic in forwardable backported to 2.3, not removed

Added by headius (Charles Nutter) almost 2 years ago. Updated 22 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
2.3.5
[ruby-core:83241]

Description

Logic was added to forwardable.rb in at least one commit, and revised in others:

https://github.com/ruby/ruby/commit/6fd18ca51bbce302865d23632b15af53d3e8f11b

On trunk, this logic was eventually replaced with code that works on Ruby impls other than MRI:

https://github.com/ruby/ruby/commit/2283d14cc9fefa278dfde02bdf8d84ce50cfe16f

I request that RubyVM not ever be used in stdlib unless guarded with a RUBY_ENGINE check plus fallback code. It is not possible for any implementation other than MRI to support RubyVM::InstructionSequence and whenever it is used in tests or stdlib we have to patch around it.

Please backport the remaining changes to forwardable to the ruby-2_3 branch for release, so we can return to using the stock forwardable.rb in JRuby.

Thank you!


Related issues

Related to Ruby master - Bug #14028: RubyVM logic backported into Ruby 2.3 testsClosedActions

History

#2

Updated by hsbt (Hiroshi SHIBATA) almost 2 years ago

  • Related to Bug #14028: RubyVM logic backported into Ruby 2.3 tests added
#3

Updated by jeremyevans0 (Jeremy Evans) 22 days ago

  • Status changed from Open to Closed

Also available in: Atom PDF