Bug #14231: __uint128_t check in hash.c is broken, use

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

[bircoph (Andrew Savchenko)]

Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.

Configure script properly checks from 128-bit data types support and
sets HAVE_UINT128_T accordingly. This approach is already used within
ruby at bignum.c, random.c, etc.

Probably hash.c is an overlooked remnant of old days. This patch fixes
this.

See also GitHub PR on this issue:
https://github.com/ruby/ruby/pull/1781

[bircoph (Andrew Savchenko)]

Looks like this version affects all ruby versions, though I tested only on 2.4.2 and trunk.

[nobu (Nobuyoshi Nakada)]

Does this mean something is broken, or just performance improvement?

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset trunk|r61471.

---

Use UINT128_T support flag from configure

Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.

Configure script properly checks from 128-bit data types support and
sets HAVE_UINT128_T accordingly. This approach is already used within
ruby at bignum.c, random.c, etc.

Probably hash.c is an overlooked remnant of old days. This patch fixes
this.

[ruby-core:84438] [Bug #14231] [Fix GH-1781]
From: Andrew Savchenko [e-mail]

[naruse (Yui NARUSE)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED

[naruse (Yui NARUSE)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r61579 merged revision(s) 61471,61472.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE to 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

ruby_2_4 r62863 merged revision(s) 61471,61472.