Project

General

Profile

Bug #14654

Resurvey performance of RDoc by frozen_string_literal: true

Added by aycabta (aycabta .) 12 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:86413]

Description

I added "frozen_string_literal: true" to RDoc by https://github.com/ruby/rdoc/pull/551. Back then, I reported "It reduces documents generation time by 5%" by https://github.com/ruby/rdoc/issues/504. The report was added to NEWS file at https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/61354/diff/NEWS.

I resurveyed it: https://gist.github.com/aycabta/abdfaa75ea8a6877eeb734e942e73800

The Pull Request https://github.com/ruby/rdoc/pull/551 has many changes for frozen string literal because RDoc expected that all strings are non-frozen. The log "before" that has "frozen_string_literal: false" is faster than the log "after-false" that has "frozen_string_literal: false". Only the implementation changes increase document generation time by 2.6%. But in the case of the same implementation, the log "after" is faster than the log "after-false". The addition "frozen_string_literal: true" reduces document generation time by 1.6%. Finally, the implementation changes and "frozen_string_literal: true" (what means https://github.com/ruby/rdoc/pull/551) increases document generation time by 0.9%.

The attached file fixes the report of NEWS file.


Files

NEWS_RDoc_performance_survey.patch (511 Bytes) NEWS_RDoc_performance_survey.patch aycabta (aycabta .), 03/31/2018 01:37 PM

Associated revisions

Revision d3d40e99
Added by naruse (Yui NARUSE) 12 months ago

Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 63048
Added by naruse (Yui NARUSE) 12 months ago

Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

Revision 63048
Added by naruse (Yui NARUSE) 12 months ago

Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

Revision 4b1fbbe9
Added by naruse (Yui NARUSE) 12 months ago

merge revision(s) 63048: [Backport #14654]

Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@63049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 63049
Added by naruse (Yui NARUSE) 12 months ago

merge revision(s) 63048: [Backport #14654]

Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

History

#1

Updated by naruse (Yui NARUSE) 12 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED
#2

Updated by naruse (Yui NARUSE) 12 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63048.


Resurvey performance of RDoc by frozen_string_literal: true [Bug #14654]

Updated by nagachika (Tomoyuki Chikanaga) 7 months ago

  • Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

Already backported at r63048.

Also available in: Atom PDF