Project

General

Profile

Misc #14962

[PATCH] thread_pthread: stop trying to deal with cancellation

Added by normalperson (Eric Wong) 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-core:88282]

Description

thread_pthread: stop trying to deal with cancellation

We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...

So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.

Am I missing something, here? Will commit in a few days.
Deleting code feels good :>

Associated revisions

Revision 2ba640f3
Added by normal 3 months ago

thread_pthread: stop trying to deal with cancellation

We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...

So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.

[Misc #14962]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 64197
Added by normalperson (Eric Wong) 3 months ago

thread_pthread: stop trying to deal with cancellation

We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...

So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.

[Misc #14962]

History

#1 Updated by normalperson (Eric Wong) 3 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r64197.


thread_pthread: stop trying to deal with cancellation

We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...

So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.

[Misc #14962]

#2 [ruby-core:88346] Updated by ko1 (Koichi Sasada) 3 months ago

I don't know about these deleted code. Who introduced?

#3 [ruby-core:88347] Updated by normalperson (Eric Wong) 3 months ago

ko1@atdot.net wrote:

I don't know about these deleted code. Who introduced?

Looks like akr did, but no reasoning was given (r47437, commit
42becbddc24ed347d67e479cccfabcc3404b24ae ) (2014-09-06))

I thought it was there longer (pre-2010) :x. Anyways, if akr or
anybody finds it necessary, it can be re-added. But I believe
it is pointless.

Also available in: Atom PDF