Misc #14962
closed[PATCH] thread_pthread: stop trying to deal with cancellation
Description
thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.
Am I missing something, here? Will commit in a few days.
Deleting code feels good :>
Files
Updated by normalperson (Eric Wong) almost 6 years ago
- Status changed from Open to Closed
Applied in changeset trunk|r64197.
thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.
[ruby-core:88282] [Misc #14962]
Updated by ko1 (Koichi Sasada) almost 6 years ago
I don't know about these deleted code. Who introduced?
Updated by normalperson (Eric Wong) almost 6 years ago
ko1@atdot.net wrote:
I don't know about these deleted code. Who introduced?
Looks like akr did, but no reasoning was given (r47437, commit
42becbddc24ed347d67e479cccfabcc3404b24ae ) (2014-09-06))
I thought it was there longer (pre-2010) :x. Anyways, if akr or
anybody finds it necessary, it can be re-added. But I believe
it is pointless.