Project

General

Profile

Actions

Bug #15339

closed

CI - add checks for std-lib CLI ?

Added by MSP-Greg (Greg L) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:90055]

Description

Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See GitHub PR #2028.


Files

pr_2028.patch (2.76 KB) pr_2028.patch MSP-Greg (Greg L), 11/25/2018 08:02 PM

Related issues 1 (0 open1 closed)

Has duplicate Ruby master - Bug #15407: bundle, bundler, irb, rdoc, ri commands broken if --program-suffix configure option is usedClosedhsbt (Hiroshi SHIBATA)Actions

Updated by MSP-Greg (Greg L) over 3 years ago

  • File pr_2028.patch added

Sorry for not mentioning it, but GH PR is just for Appveyor. Not sure if code should be added to all Travis builds...

PR CI failed for all three builds on Appveyor. All errors similar to:

\usr\bin\bundle --version
C:/usr/bin/bundle.cmd:33:in `load': cannot load such file -- C:/usr/lib/ruby/gems/2.6.0/gems/bundler-2.0.0.pre.1/exe/bundle (LoadError)
	from C:/usr/bin/bundle.cmd:33:in `<main>'

Command exited with code 1

Something must be wrong with the bundler install code.

Patch attached.

Updated by Anonymous over 3 years ago

How about creating this check in make task "make test" or "make test-all"?

Updated by MSP-Greg (Greg L) over 3 years ago

@junaruga

  1. I believe I have seen discussions on whether make install should be included in CI or not.

  2. The test suites can be run before make install.

  3. I'm not a good choice for making changes re Makefile, especially for cross platform use.

Given the above, I thought starting with Ruby's own Windows CI would be a good start.

JFYI, ruby-loco is running every test suite except basic from install (without using make). The build folder could be deleted beforehand. There were a few files that needed changing for that...

Thanks, Greg

Actions #4

Updated by MSP-Greg (Greg L) over 3 years ago

  • File deleted (pr_2028.patch)

Updated by MSP-Greg (Greg L) over 3 years ago

Added 3 lines to rbinstall.rb, added bundle_ruby to Bundler's executables.

Both are minor fixups to r65963. Passes on Appveyor. Patch file updated. Nothing changed re Travis...

Updated by hsbt (Hiroshi SHIBATA) over 3 years ago

  • Assignee set to hsbt (Hiroshi SHIBATA)
  • Status changed from Open to Assigned

Updated by hsbt (Hiroshi SHIBATA) over 3 years ago

  • Status changed from Assigned to Closed

Hi Greg.

Thanks for your report.
This is fixed ar r66384 by @usa (Usaku NAKAMURA).

I will consider to add cli check to our CI after Ruby 2.6 releasing.

Actions #8

Updated by naruse (Yui NARUSE) over 3 years ago

  • Has duplicate Bug #15407: bundle, bundler, irb, rdoc, ri commands broken if --program-suffix configure option is used added
Actions

Also available in: Atom PDF