Project

General

Profile

Bug #15391

JIT does not respect configuration options

Added by vo.x (Vit Ondruch) 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.6.0dev (2018-12-06 trunk 66252) [x86_64-linux]
[ruby-core:90365]

Description

JIT does not respect configuration options, mainly the header location options --with-rubyhdrdir, --with-rubyarchhdrdir, but it also ignores --with-ruby-version if I am not mistaken.

So far I came up with the patch attached. But while it seems it places the headers on reasonable places, there are 80+ JIT test cases failed, because it obviously tries to locate the file on a place (e.g. absolute path) specified by configuration, but such place is not available during a build.


Files

Associated revisions

Revision 7aea1e65
Added by nobu (Nobuyoshi Nakada) 11 months ago

Honor configured ruby header locations as the MJIT header path

[Bug #15391]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 66282
Added by nobu (Nobuyoshi Nakada) 11 months ago

Honor configured ruby header locations as the MJIT header path

[Bug #15391]

Revision 66282
Added by nobu (Nobuyoshi Nakada) 11 months ago

Honor configured ruby header locations as the MJIT header path

[Bug #15391]

History

Updated by k0kubun (Takashi Kokubun) 11 months ago

  • Assignee changed from k0kubun (Takashi Kokubun) to nobu (Nobuyoshi Nakada)
  • Status changed from Open to Feedback

there are 80+ JIT test cases failed

Then, we can't merge, right?

Also most of the changed places are mostly written by @nobu. Reassigning this to him because TBH I have no idea about how multi-arch build is working.

#2

Updated by nobu (Nobuyoshi Nakada) 11 months ago

  • Status changed from Feedback to Closed

Applied in changeset trunk|r66282.


Honor configured ruby header locations as the MJIT header path

[Bug #15391]

Also available in: Atom PDF