Range#=== is not using cover in Ruby 2.6
irb(main):105:0> ('A'..'Z').cover? 'ANA' => true irb(main):106:0> ('A'..'Z') === 'ANA' => false
Is this expected? Should
=== use cover according to NEWS in Ruby 2.6?
> ruby -v ruby 2.6.0dev (2018-12-20 trunk 66466) [x86_64-linux]
Updated by jeremyevans0 (Jeremy Evans) over 1 year ago
- Backport changed from 2.4: UNKNOWN, 2.5: UNKNOWN to 2.5: DONTNEED, 2.6: REQUIRED
- File range-case-cover-string.patch range-case-cover-string.patch added
I agree that this is a bug, and not the intended behavior now that
Range#cover? in most cases. Hopefully nobu can confirm. Attached is a patch that fixes the behavior.
I think this should be backported to 2.6, assuming this behavior is not intentional.
Updated by jeremyevans (Jeremy Evans) over 1 year ago
- Status changed from Open to Closed
Applied in changeset git|6954ff1dcb538ee6c042872088b64464a1ef6089.
Make Range#=== operate like cover? instead of include? for string ranges
Previously, Range#=== treated string ranges that were not endless or
beginless the same as include?, instead of the same as cover?.
I think this was an oversight in 989e07c0f2fa664a54e52a475c2fcc145f06539d,
as the commit message did not indicate this behavior was desired.
This also makes some previously dead code no longer dead. Previously,
the conditionals were doing this:
if (RB_TYPE_P(beg, T_STRING) if (NIL_P(beg)) # can never be true
This restructures it so at the NIL_P(beg) check, beg could possibly
be nil (beginless ranges).
Fixes [Bug #15449]