Project

General

Profile

Bug #15717

Backport #15270 to Ruby 2.5.x

Added by alanwu (Alan Wu) 7 months ago. Updated 6 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-darwin18]
[ruby-core:91902]

Description

There is a commit that claims to backport #15270, ruby_2_5@66225 / aba207b7620d963e212e4187213db7e1eee7a790.
However, the patch in #15270 wasn't actually backported. For reference, here is a script that outputs

"2.6.2"
3
4
"class 1"
"class 2"

On Ruby 2.6.2, but only outputs

"2.5.5"

on Ruby 2.5.5.

p RUBY_VERSION
iseq = RubyVM::InstructionSequence.compile(<<-RUBY)
  class A
    class B
    end
  end
RUBY

iseq_bin = iseq.to_binary
TracePoint.new(:end){|tp|
  p tp.lineno
}.enable{
  RubyVM::InstructionSequence.load_from_binary(iseq_bin).eval
}

TracePoint.new(:class){|tp|
  p "class #{tp.lineno}"
}.enable{
  RubyVM::InstructionSequence.load_from_binary(iseq_bin).eval
}

If it helps, can we also backport the tests in the patch in #15270?


Related issues

Related to Ruby master - Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binaryClosedActions

History

#1

Updated by alanwu (Alan Wu) 7 months ago

  • Description updated (diff)
#2

Updated by nagachika (Tomoyuki Chikanaga) 6 months ago

  • Related to Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary added
#3

Updated by nagachika (Tomoyuki Chikanaga) 6 months ago

  • Backport changed from 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN to 2.4: DONTNEED, 2.5: REQUIRED, 2.6: DONTNEED

Also available in: Atom PDF