Project

General

Profile

Bug #15877

Incorrect constant lookup result in method on cloned class

Added by danielwaterworth (Daniel Waterworth) 25 days ago. Updated 24 days ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:92849]

Description

This behavior seems wrong to me:

class Foo
  def test
    TEST
  end
end

Bar1 = Foo.clone
Bar2 = Foo.clone

class Bar1
  TEST = 'bar-1'
end

class Bar2
  TEST = 'bar-2'
end

# If these two lines are reordered, 'bar-2' is produced each time
p [:bar1_method, Bar1.new.test] # outputs 'bar-1' (correct)
p [:bar2_method, Bar2.new.test] # outputs 'bar-1' (incorrect)

p [:bar1_const, Bar1::TEST] # outputs 'bar-1' (correct)
p [:bar2_const, Bar2::TEST] # outputs 'bar-2' (correct)

Possibly related to #9603, #7107

History

Updated by danielwaterworth (Daniel Waterworth) 25 days ago

Running with RubyVM::InstructionSequence.compile_option = {inline_const_cache: false} produces the correct result.

#2

Updated by danielwaterworth (Daniel Waterworth) 25 days ago

  • Description updated (diff)

Updated by sag (Stephen Gregory) 24 days ago

I tested this on 2.5, 2.4 and the behavior is the same there. Also this applies to subclasses as well. The first class READ determines the values for all of them.

class Unrelated
    TEST='UNRELATED'
    def test
      TEST
    end
end

class Foo
  def test
     TEST
   end
end

Bar2 = Foo.clone
Bar1 = Foo.clone


class Bar1
  TEST = 'bar-1'
end
class Bar2
  TEST = 'bar-2'
end
class Bar3 < Foo
  TEST = 'bar-3'
end

puts "Bar2 #{Bar2.new.test}"  # Bar2 bar-2
puts "Bar1 #{Bar1.new.test}"   # Bar1 bar-2
puts "Bar3 #{Bar3.new.test}"  # Bar3 bar-2
puts "Foo #{Foo.new.test}"     # Foo bar-2
puts "Unrelated #{Unrelated.new.test}"  #Unrelated UNRELATED

Interestingly if Bar3 is read first then you get:

sample/array_second.rb:12:in `test': uninitialized constant Foo::TEST (NameError)
    from sample/array_second.rb:30:in `<main>'

Also available in: Atom PDF