Project

General

Profile

Bug #15969

https://git.ruby-lang.org/ruby.git does not work?

Added by vo.x (Vit Ondruch) 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby-2.7.0-76851381cb
[ruby-core:93450]

Description

On ruby-core documentation page 1, there is referenced https://git.ruby-lang.org/ruby.git 2, but the following fails:

$ git clone https://git.ruby-lang.org/ruby.git
Cloning into 'ruby'...
fatal: repository 'https://git.ruby-lang.org/ruby.git/' not found

as well as make-snapshot, which refers the same URL 3, fails:

$ tool/make-snapshot -packages=xz -git tmp 
Exporting @76851381cb18a62f3a75720f868ac147e4c1c51c
Cloning into '/tmp/ruby-snapshot20190701-113-1o5vpl3/ruby'...
fatal: repository 'https://git.ruby-lang.org/ruby.git/' not found
Traceback (most recent call last):
    6: from tool/make-snapshot:522:in `<main>'
    5: from tool/make-snapshot:522:in `collect'
    4: from tool/make-snapshot:522:in `block in <main>'
    3: from tool/make-snapshot:262:in `package'
    2: from /builddir/ruby/tool/vcs.rb:541:in `export'
    1: from /builddir/ruby/tool/vcs.rb:111:in `system'
/builddir/ruby/tool/vcs.rb:111:in `system': Command failed with exit 128: git (RuntimeError)

So is this URL supposed to work? Should be the GitHub URL used instead?

Associated revisions

Revision 0b858425
Added by k0kubun (Takashi Kokubun) 3 months ago

Use GitHub ruby.git for make-snapshot

Previously hsbt (Hiroshi SHIBATA) disabled https git clone from git.ruby-lang.org.

Using git.ruby-lang.org for non-commit purposes is discouraged. GitHub
mirror is actually recommended because it's reliable than single-hosted
git.ruby-lang.org, the mirror is almost always well-maintained, and its
latency is very small (usually about 10s).

So we should just use GitHub here.

[Bug #15969]

History

Updated by k0kubun (Takashi Kokubun) 3 months ago

On ruby-core documentation page 1, there is referenced https://git.ruby-lang.org/ruby.git

Yes, but

but the following fails

The documentation does not mention git clone https://git.ruby-lang.org/ruby.git at all. The https URL https://git.ruby-lang.org/ruby.git is referenced for a browsing purpose.

As GitHub is more reliable than single-hosted git.ruby-lang.org and there's only about 10s latency in GitHub mirror, we always recommend to clone ruby.git via GitHub (https / ssh). hsbt (Hiroshi SHIBATA) allowed only ssh access to git clone git.ruby-lang.org because it's supposed to be used only by commiters for that reason.

as well as make-snapshot, which refers the same URL 3, fails

Should be the GitHub URL used instead?

You're right. I believe we should use GitHub for it too.

Updated by vo.x (Vit Ondruch) 3 months ago

k0kubun (Takashi Kokubun) wrote:

On ruby-core documentation page 1, there is referenced https://git.ruby-lang.org/ruby.git

Yes, but

but the following fails

The documentation does not mention git clone https://git.ruby-lang.org/ruby.git at all. The https URL https://git.ruby-lang.org/ruby.git is referenced for a browsing purpose.

Ah, it somehow did not come to my mind that this is actually GitWeb link, especially comparing to the make-snapshot (that was actually the first issue I encountered, just tried to find some other link ...)

May be it would be useful to somehow explain the situation, that everybody is really expected to used the GH mirror, because for me mirror is just mirror, but I want the source code from its canonical location.

As GitHub is more reliable than single-hosted git.ruby-lang.org and there's only about 10s latency in GitHub mirror, we always recommend to clone ruby.git via GitHub (https / ssh). hsbt (Hiroshi SHIBATA) allowed only ssh access to git clone git.ruby-lang.org because it's supposed to be used only by commiters for that reason.

as well as make-snapshot, which refers the same URL 3, fails

Should be the GitHub URL used instead?

You're right. I believe we should use GitHub for it too.

That would be nice.

#3

Updated by k0kubun (Takashi Kokubun) 3 months ago

  • Status changed from Open to Closed

Applied in changeset git|0b858425e1e4f2de40dc0d8e5dd105a2fd93e478.


Use GitHub ruby.git for make-snapshot

Previously hsbt (Hiroshi SHIBATA) disabled https git clone from git.ruby-lang.org.

Using git.ruby-lang.org for non-commit purposes is discouraged. GitHub
mirror is actually recommended because it's reliable than single-hosted
git.ruby-lang.org, the mirror is almost always well-maintained, and its
latency is very small (usually about 10s).

So we should just use GitHub here.

[Bug #15969]

Also available in: Atom PDF