winruby UTF8 Fallback for no CodePage
This is to deal specifically with setting the Region to Arabic which
sets the codepage to 720. This codepage isn't recognised by Ruby which
causes it to fail during initialisation when setting up LOCALE.
This patch to Ruby is necessary to handle languages/regions on windows
where the codepage is not supported by Ruby such as Arabic which uses
If the codepage is not found, the Locale falls back to UTF8.
This is a well known Ruby/Ruby on Rails issue which is described at
Opened PR: https://github.com/ruby/ruby/pull/2518
Updated by gabuscus (Gabriel Nagy) 12 months ago
duerst (Martin Dürst) wrote:
If codepage 720 is not supported, then we should look at supporting it.
fair point, however investigation on this Puppet ticket: https://tickets.puppetlabs.com/browse/PA-2191 concluded that falling back to UTF-8 fixes the issue (for codepage 720 at least). we could also check the codepage when catching the ArgumentError so we fallback only in that case
edit: also I'm not sure what does adding a new codepage entail? I agree that would be the cleaner solution
Updated by naruse (Yui NARUSE) 8 months ago
- Backport deleted (
2.5: UNKNOWN, 2.6: UNKNOWN)
- ruby -v deleted (
- Target version set to 2.8
- Assignee set to duerst (Martin Dürst)
- Tracker changed from Bug to Feature
It looks Ruby should support CP720.
duerst (Martin Dürst) Could you add support for it?
Updated by duerst (Martin Dürst) 8 months ago
Will do, but probably not very soon, because it's now the most busy time of the year at work, sorry.
Some notes: For the encoding (onigX), windows-1256 is a replica of iso-8859-6. But windows-1256 is much more complete, while iso-8859-6 has many unassigned codepoints, so it may be a good idea to fix this if we get around to it.
Just adding an alias 'CP720' for windows-1256 is much easier.