Project

General

Profile

Bug #16233

winruby UTF8 Fallback for no CodePage

Added by gabuscus (Gabriel Nagy) about 1 month ago. Updated about 1 month ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
2.6.3
[ruby-core:95196]

Description

This is to deal specifically with setting the Region to Arabic which
sets the codepage to 720. This codepage isn't recognised by Ruby which
causes it to fail during initialisation when setting up LOCALE.

This patch to Ruby is necessary to handle languages/regions on windows
where the codepage is not supported by Ruby such as Arabic which uses
codepage 720.
If the codepage is not found, the Locale falls back to UTF8.

This is a well known Ruby/Ruby on Rails issue which is described at
https://stackoverflow.com/questions/22815542/rails4-unknown-encoding-name-cp720

Opened PR: https://github.com/ruby/ruby/pull/2518


Files

windows_nocodepage_utf8_fallback_r2.5.patch (946 Bytes) windows_nocodepage_utf8_fallback_r2.5.patch patch to fix the issue gabuscus (Gabriel Nagy), 10/03/2019 07:27 AM

History

#1

Updated by gabuscus (Gabriel Nagy) about 1 month ago

  • Description updated (diff)

Updated by duerst (Martin Dürst) about 1 month ago

If codepage 720 is not supported, then we should look at supporting it.

Updated by gabuscus (Gabriel Nagy) about 1 month ago

duerst (Martin Dürst) wrote:

If codepage 720 is not supported, then we should look at supporting it.

fair point, however investigation on this Puppet ticket: https://tickets.puppetlabs.com/browse/PA-2191 concluded that falling back to UTF-8 fixes the issue (for codepage 720 at least). we could also check the codepage when catching the ArgumentError so we fallback only in that case

edit: also I'm not sure what does adding a new codepage entail? I agree that would be the cleaner solution

Also available in: Atom PDF