Project

General

Profile

Actions

Feature #16963

open

Remove English.rb from Ruby 2.8/3.0

Added by hsbt (Hiroshi SHIBATA) over 1 year ago. Updated about 1 year ago.

Status:
Assigned
Priority:
Normal
Target version:
-
[ruby-core:98826]

Description

English.rb is no longer maintained by ruby core team.

Can we remove it from our repository? The users can install if from rubygems.org now.


Related issues

Related to Ruby master - Feature #14138: Define English.rb aliases by default and eliminate the libraryClosedActions

Updated by retro (Josef Šimánek) over 1 year ago

I'm all in for this since this one will help to "normalize" standard library naming (this one is also having "exotic" file name with capital first letter).

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Status changed from Open to Assigned
mame@gem-codesearch:~$ csearch "require 'English'" | wc -l
866
mame@gem-codesearch:~$ csearch "require \"English\"" | wc -l
273

We found the usage of English.rb like capybara that is the famous gem. I have a bit of aware to affect this proposal.

Updated by deivid (David Rodríguez) over 1 year ago

I'm surprised by the low usage you found anyways, since rubocop and its style guide recommend English and enforce it by default. Honestly, I'd like all English names to be there by default without having to require anything.

Actions #4

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Related to Feature #14138: Define English.rb aliases by default and eliminate the library added

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

deivid (David Rodríguez)

See #14138 . We have a plan to remove it at Ruby 3.

Updated by deivid (David Rodríguez) over 1 year ago

Nice, I didn't know that. Something I don't quite get is, if the functionality of English will be the default (in ruby 2.8, I guess?), what's the point of gemifying it?

Updated by Eregon (Benoit Daloze) over 1 year ago

I think we should define these aliases in core, and then English.rb does nothing.

Removing it from the standard library seems too incompatible to me.

Updated by deivid (David Rodríguez) about 1 year ago

Agreed!

We should at least add a warning on top of English.rb for a full release cycle before removing it.

Actions

Also available in: Atom PDF