Project

General

Profile

Actions

Bug #17609

closed

addr2line.c: wrong operand size of DW_LNS_fixed_advance_pc

Added by xtkoba (Tee KOBAYASHI) over 3 years ago. Updated over 2 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [riscv64-linux]
[ruby-core:102394]

Description

According to the standards, DW_LNS_fixed_advance_pc takes a single uhalf operand. A patch is attached to conform to them.

With this change, we can safely revert the commit 6985bfb72c8d7e7d94f1aad1f0902b602bbfa6da (vm_dump.c: Do not show C backtrace on riscv).


Files

ruby-addr2line-DW_LNS_fixed_advance_pc.patch (268 Bytes) ruby-addr2line-DW_LNS_fixed_advance_pc.patch Fix the operand size of DW_LNS_fixed_advance_pc xtkoba (Tee KOBAYASHI), 02/04/2021 07:48 AM
ruby-revert-commit-6985bfb72c8d7e7d94f1aad1f0902b602bbfa6da.patch (505 Bytes) ruby-revert-commit-6985bfb72c8d7e7d94f1aad1f0902b602bbfa6da.patch Revert commit 6985bfb72c8d7e7d94f1aad1f0902b602bbfa6da xtkoba (Tee KOBAYASHI), 02/04/2021 07:48 AM
Actions #1

Updated by mame (Yusuke Endoh) over 3 years ago

  • Status changed from Open to Closed

Applied in changeset git|7d22060c14895bbca3ff962e5456384095b66738.


addr2line.c: DW_LNS_fixed_advance_pc takes a single uhalf operand

Fixes [Bug #17609]

Co-Authored-By: xtkoba (Tee KOBAYASHI)

Updated by mame (Yusuke Endoh) over 3 years ago

Thanks! I've committed your patch. I'll check the RISC-V CI later: http://rubyci.s3.amazonaws.com/debian-riscv64/ruby-master/recent.html

Actions #3

Updated by nagachika (Tomoyuki Chikanaga) over 2 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 2 years ago

  • Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED to 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE

ruby_3_0 7b4bc893941b146565c396606effb5f16aa9e88d merged revision(s) 7d22060c14895bbca3ff962e5456384095b66738.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0