Project

General

Profile

Actions

Bug #17644

closed

Ripper.lex fails with syntax error and heredoc

Added by shugo (Shugo Maeda) about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 3.1.0dev (2021-02-18T13:35:34Z master 7b9476fbfa) [x86_64-darwin19]
[ruby-dev:<unknown>]

Description

Ripper.lex fails with syntax error and heredoc:

$ cat t.rb
require "ripper"
s = <<~EOF
    foo
  end
  <<~EOS
    bar
  EOS
EOF
p Ripper.lex(s)
$ ruby t.rb
/Users/shugo/.rbenv/versions/master/lib/ruby/3.1.0/ripper/lexer.rb:110:in `each': undefined method `pos' for [#<Ripper::Lexer::Elem: on_heredoc_beg@3:0:BEG: "<<~EOS">, #<Ripper::Lexer::Elem: on_ignored_sp@4:0:BEG: "  ">, #<Ripper::Lexer::Elem: on_tstring_content@4:2:BEG: "bar\\n">, #<Ripper::Lexer::Elem: on_heredoc_end@5:0:BEG: "EOS\\n">]:Array (NoMethodError)
Did you mean?  pop
        from /Users/shugo/.rbenv/versions/master/lib/ruby/3.1.0/ripper/lexer.rb:110:in `sort_by'
        from /Users/shugo/.rbenv/versions/master/lib/ruby/3.1.0/ripper/lexer.rb:110:in `lex'
        from /Users/shugo/.rbenv/versions/master/lib/ruby/3.1.0/ripper/lexer.rb:52:in `lex'
        from t.rb:9:in `<main>'

It seems that this bug was introduced by 69d871eeeb2.

Actions #1

Updated by shugo (Shugo Maeda) about 1 year ago

  • Status changed from Open to Closed

Applied in changeset git|5de38c41ae7bf17ae599fdfa9f8face87f16d8bb.


ripper: fix a bug of Ripper::Lexer with syntax error and heredoc [Bug #17644]

Actions #2

Updated by nobu (Nobuyoshi Nakada) about 1 year ago

  • Description updated (diff)

Updated by naruse (Yui NARUSE) about 1 year ago

  • Backport changed from 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONE

ruby_3_0 a6dec2e144d65011d49f272e494bf62daf3d7531 merged revision(s) 5de38c41ae7bf17ae599fdfa9f8face87f16d8bb.

Actions

Also available in: Atom PDF