Project

General

Profile

Actions

Bug #17675

closed

StringIO#each_byte doesn't check for readabilty while iterating

Added by wyhaines (Kirk Haines) 11 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:102764]

Description

Bug #17661 is a failure to check readability on each_byte of an IO, causing a segmentation fault.

StringIO has an independent, but related implementation, and it shares the same flaw in its implementation, where it fails to check for the readability of the StringIO object while iterating over the bytes. Unlike IO, this does not result in a segmentation fault. It does, however, allow the continued reading from an object that has been closed.

require "stringio"

strio = StringIO.new
strio.each_byte do |byte|
  puts byte
  strio.close
end

That code should print the first byte, and then throw an IOError, but instead, it iterates through the entire data buffer for the object, calling the block for each byte, without ever raising an exception.

I have a PR for this which I will submit on Github and link to.
The PR simply inserts an appropriate check into the loop for each_byte.

Actions #3

Updated by nobu (Nobuyoshi Nakada) 11 months ago

  • Status changed from Open to Closed

Updated by nagachika (Tomoyuki Chikanaga) 2 months ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE

Backported into ruby_3_0 at e6fced73e55dda487f026c929d97542cf1832252. Thank you hsbt san.

Actions

Also available in: Atom PDF