Project

General

Profile

Actions

Bug #17759

closed

Correct `ioctl_req_t` for musl

Added by xtkoba (Tee KOBAYASHI) 7 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:103080]

Description

The definition of ioctl(2) in musl is int ioctl (int, int, ...);, and this makes io.c fail to build on 64-bit musl environments with Clang/LLVM due to shorten-64-to-32 error.

A patch is attached for a workaround. It is expected to work with glibc, musl, bionic (Android), and uClibc (which defines __GLIBC__). I have no idea of other C libraries working on Linux.

Aside from this patch, it might be better if we could supply ./configure with the definition of ioctl_req_t using e.g. rb_cv_ioctl_req_t_convertible=....


Files

ruby-ioctl_req_t.patch (473 Bytes) ruby-ioctl_req_t.patch xtkoba (Tee KOBAYASHI), 03/29/2021 08:56 AM

Updated by nobu (Nobuyoshi Nakada) 7 months ago

Seems more concise.
Would you commit it by yourself?

Updated by mame (Yusuke Endoh) 7 months ago

Would you commit it by yourself?

+1

Updated by mame (Yusuke Endoh) 6 months ago

Hi xtkoba (Tee KOBAYASHI)

Are you ineterested in becoming a Ruby commiter?
At least, nobu (Nobuyoshi Nakada) and I want you to have a commit bit.
If you don't mind, we will recommend that we add you as a committer.

Actions #4

Updated by nobu (Nobuyoshi Nakada) 4 months ago

  • Status changed from Open to Closed

Applied in changeset git|c2d9967f78d2e6f93f8d9876c2b3ab25aa6b86e7.


Configure ioctl request argument type [Bug #17759]

Actions

Also available in: Atom PDF