Bug #18016: fiddle\types.rb typealias maybe wrong

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x64-mingw32]
• Backport: 2.6: UNKNOWN, 2.7: DONE, 3.0: DONE

[fitmap (Justin Peal)]

in ...\lib\ruby\3.0.0\fiddle\types.rb

module Fiddle
module Win32Types
def included(m) # :nodoc:
m.module_eval{
# ...
typealias "HANDLE", "uintptr_t"
# ...
typealias "HINSTANCE", "unsigned int"
typealias "HDC", "unsigned int"
typealias "HWND", "unsigned int"
}
end
module_function :included
end

...

end

HINSTANCE, HDC, HWND are pointers to struct, so in 64-bit system, the size of them will be 64 bits, not unsigned int (32bits).

In minwindef.h :

DECLARE_HANDLE(HINSTANCE);

In windef.h :

DECLARE_HANDLE(HDC);
DECLARE_HANDLE (HWND);

In winnt.h :

#define DECLARE_HANDLE(name) struct name##{int unused;}; typedef struct name## *name

So I suggest typealias in types.rb change to:

    typealias "HINSTANCE", "void*"
    typealias "HDC", "void*"
    typealias "HWND", "void*"

[jeremyevans0 (Jeremy Evans)]

• Status changed from Open to Closed
• Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED

This was fixed upstream just after the release of 3.0: https://github.com/ruby/fiddle/commit/28ee5b16086f77e1f079853bff2ee1cb527cb69c. These changes have already been applied to the master branch. Possibly 8758b07b1e4fd636dffb4b442388a3033c63d4b5 needs to be backported to 3.0 and 2.7.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE

ruby_3_0 c4b602e80fdc1824c68602302a4ed82a0e90d5b7 merged revision(s) 25e56fe374478a2266ac25f22a07bb3c6a423c83,8758b07b1e4fd636dffb4b442388a3033c63d4b5,791e8eec66d3aebcee36c1369b0bf52bc3815e94.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE to 2.6: UNKNOWN, 2.7: DONE, 3.0: DONE

ruby_2_7 6601fb5672dc4c1f4bf5ee0f9b3f97a029df06cd merged revision(s) 25e56fe374478a2266ac25f22a07bb3c6a423c83,8758b07b1e4fd636dffb4b442388a3033c63d4b5,791e8eec66d3aebcee36c1369b0bf52bc3815e94.