Project

General

Profile

Actions

Feature #18183

open

make SecureRandom.choose public

Added by olleicua (Antha Auciello) 8 months ago. Updated 5 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:105361]

Description

This issue https://bugs.ruby-lang.org/issues/10849
added SecureRandom.alphanumeric and also the private method choose.
choose was kept private because the method name wasn't the best name to represent the behavior.
I think if it was called random_string it would be very clear what it does.
I also think it should be aliased to choose as well to allow backwards compatibility for people bypassing the private method with send (e.g. https://www.thetopsites.net/article/58611103.shtml)

I'm planning to put together a pull request for this. Please let me know if there are any complications I'm not considering.


Related issues 2 (0 open2 closed)

Related to Ruby master - Feature #10849: Adding an alphanumeric function to SecureRandomClosedandrewcbutterfield@gmail.com (Andrew Butterfield)Actions
Related to Ruby master - Feature #18190: Split `Random::Formatter` from securerandomClosedActions
Actions #2

Updated by nobu (Nobuyoshi Nakada) 8 months ago

  • Related to Feature #10849: Adding an alphanumeric function to SecureRandom added
Actions #3

Updated by nobu (Nobuyoshi Nakada) 6 months ago

  • Related to Feature #18190: Split `Random::Formatter` from securerandom added

Updated by matz (Yukihiro Matsumoto) 5 months ago

I agree with the proposal, but choice is not a good name for a public method.

Matz.

Actions

Also available in: Atom PDF