Feature #1927

rb_w32_readdir seems to be superseded by rb_w32_readdir_with_enc

Added by Vit Ondruch over 5 years ago. Updated over 2 years ago.

[ruby-core:24864]
Status:Closed
Priority:High
Assignee:Usaku NAKAMURA

Description

=begin
Function rb_w32_readdir seems to be superseded by function rb_w32_readdir_with_enc. It renders rb_w32_readdir useless and it should be removed from source code to avoid confusion.

Or better, rb_w32_readdir_with_enc should be renamed back to rb_w32_readdir.
=end

Associated revisions

Revision 38534
Added by Usaku NAKAMURA over 2 years ago

  • win32/{dir.h,win32.c} (rb_w32_readdir): removed old rb_w32_readdir()
    and renamed from rb_w32_readdir_with_enc().
    [Feature #1927]

  • dir.c (READDIR): follow above change.

Revision 38534
Added by Usaku NAKAMURA over 2 years ago

  • win32/{dir.h,win32.c} (rb_w32_readdir): removed old rb_w32_readdir()
    and renamed from rb_w32_readdir_with_enc().
    [Feature #1927]

  • dir.c (READDIR): follow above change.

History

#1 Updated by Usaku NAKAMURA over 5 years ago

  • Status changed from Open to Assigned
  • Assignee set to Usaku NAKAMURA
  • Target version set to 2.0.0

=begin
ruby 1.9.1-p0 has rb_w32_readdir(), so we cannot remove it or change its signature to secure binary compatibility.
There might be a chance when the binary version will be updated.
=end

#2 Updated by Usaku NAKAMURA over 5 years ago

  • Priority changed from Normal to Low

=begin

=end

#3 Updated by Usaku NAKAMURA over 2 years ago

  • Description updated (diff)

I'll be remove it (and other useless APIs) before code freeze.

#4 Updated by Yusuke Endoh over 2 years ago

  • Priority changed from Low to High

Usa-san, is there any reason for the task to wait immediately before code freeze?
If there is no reason, and if you are willing to do the task for 2.0, please do so asap.

Yusuke Endoh mame@tsg.ne.jp

#5 Updated by Usaku NAKAMURA over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38534.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • win32/{dir.h,win32.c} (rb_w32_readdir): removed old rb_w32_readdir()
    and renamed from rb_w32_readdir_with_enc().
    [Feature #1927]

  • dir.c (READDIR): follow above change.

Also available in: Atom PDF