Project

General

Profile

Actions

Bug #20161

closed

Memory leak in regexp grapheme clusters

Added by peterzhu2118 (Peter Zhu) 4 months ago. Updated about 2 months ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:116073]

Description

GitHub PR: https://github.com/ruby/ruby/pull/9447

The cc->mbuf gets overwritten, so we need to free it to not leak memory.

For example:

str = "hello world".encode(Encoding::UTF_32LE)

10.times do
  1_000.times do
    str.grapheme_clusters
  end

  puts `ps -o rss= -p #{$$}`
end

Before:

15536
15760
15920
16144
16304
16480
16640
16784
17008
17280

After:

15584
15584
15760
15824
15888
15888
15888
15888
16048
16112
Actions #1

Updated by peterzhu2118 (Peter Zhu) 4 months ago

  • Status changed from Open to Closed

Applied in changeset git|37ed86fd3c798e298fad9db6e7df1f3f45e1e03b.


Fix memory leak in regexp grapheme clusters

[Bug #20161]

The cc->mbuf gets overwritten, so we need to free it to not leak memory.

For example:

str = "hello world".encode(Encoding::UTF_32LE)

10.times do
  1_000.times do
    str.grapheme_clusters
  end

  puts `ps -o rss= -p #{$$}`
end

Before:

15536
15760
15920
16144
16304
16480
16640
16784
17008
17280

After:

15584
15584
15760
15824
15888
15888
15888
15888
16048
16112

Updated by nagachika (Tomoyuki Chikanaga) 4 months ago

  • Backport changed from 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED to 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONE, 3.3: REQUIRED

ruby_3_2 a26b41bf7a2db69b0889ed599f568a4ba2529eba merged revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b.

Updated by naruse (Yui NARUSE) about 2 months ago

  • Backport changed from 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONE, 3.3: REQUIRED to 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONE, 3.3: DONE

ruby_3_3 577f9c7a8334bb33512f01e7db95f6fb15e280b2 merged revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0