Feature #20329: Clean up `--dump` sub-options

• Status: Closed
• Assignee: -
• Target version: -

[nobu (Nobuyoshi Nakada)]

Currently we have 5 options for --dump command line option.

• insns
• insns_without_opt
• yydebug(+error-tolerant)
• parsetree(+error-tolerant)
• parsetree_with_comment(+error-tolerant)

Among these, insns_without_opt is a variant of insns, and parsetree_with_comment is a variant of parsetree.
However, there is now another way to specify variants (e.g. +error-tolerant).
How about unifying the two so that the former can also be specified in the same form, such as --dump=parsetree+comment+error-tolerant?
It also will be able to abbreviate as parse+comm+err or more.

[k0kubun (Takashi Kokubun)]

What will replace insns? I don't want to type insns+opt every single time. If it stays as is and insns_without_opt is changed to insns-opt (insns minus opt) or something, I'm good.

[nobu (Nobuyoshi Nakada)]

--dump=insns will not be changed.
Since + is the separator, insns+-opt will be same as the current insns_without_opt.

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

[eightbitraptor (Matt V-H)]

I don't feel particularly strongly about this, but something about have +- in the argument feels a little clunky to me.

I understand the desire to not change the existing options like --dump=insns, and that we've got ourselves into a state where we have both with and without, but what about if we changed the + to , - similar to how you pass options to the linker through gcc. Something like:

dump=insns
dump=insns,-opt
dump=parsetree,+error-tolerant,+comment
dump=yydebug,+error_tolerant
...etc...

[nobu (Nobuyoshi Nakada)]

eightbitraptor (Matthew Valentine-House) wrote in #note-4:

dump=insns
dump=insns,-opt
dump=parsetree,+error-tolerant,+comment
dump=yydebug,+error_tolerant
...etc...

This looks nice.

Would --dump=insns --dump=-opt have the same effect with --dump=insns,-opt?

[eightbitraptor (Matt V-H)]

nobu (Nobuyoshi Nakada) wrote in #note-5:

This looks nice.

Would --dump=insns --dump=-opt have the same effect with --dump=insns,-opt?

seems like a good idea.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset git|9b5d4274a247567c583667f4c8442872d8765d39.

---

[Feature #20329] Clean up dump sub-options

Restructure insns_without_opt and parsetree_with_comment as
insns+without_opt and parsetree+with_comment respectively, like
+error-tolerant.