Bug #20647: Invalid return in class/module body from within singleton class

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN

[kddnewton (Kevin Newton)]

Currently, Ruby will raise a syntax error for invalid returns within class and module bodies, but skips it for singleton classes. I think we should be able to add this same error for singleton classes, as I believe these always raise a LocalJumpError.

class << Object
  return
end

[zverok (Victor Shepelev)]

That’s actually interesting, because return in the middle of the class body, while might be considered questionable, is also meaningful.

I think making it a syntax error in normal classes was (probably?) a decision from before 2.4 (when top-level return had no useful semantics).

I can imagine code like

class MyService
  # some generic stuff

  return if RUBY_PLATFORM.match?(/windows/i)

  # some Unix-only stuff
end

...and even more so, the same in the middle of a singleton class definition in some DSL method :shrug:

[nobu (Nobuyoshi Nakada)]

https://github.com/ruby/ruby/pull/11234

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset git|e642ddf7ae86e306674559ae745823fdbf56ea10.

---

[Bug #20647] Disallow return directly within a singleton class