Misc #21688
closedRuby::Box maturing path
Description
A quick couple of questions in the light of upcoming Ruby 4.0 release and Ruby::Box being available there (even if as an experimental feature):
- Should the documentation of the class be available as RDoc? I mean, as standard class documentation at https://docs.ruby-lang.org/en/master/Ruby/Box.html (404 currently). It seems like RDoc-formatted comments are present in the code but never rendered. Are PRs to make the docs rendered and/or improve/expand them welcome, or would it be just distracting?
- Should small(ish) problems/suggestions be reported? Can they be submitted as PRs? (I mean, things like "in some cases,
#inspectof the class in the Box is weird", and other stuff like this) Or this would be just distracting from the main work?
Thanks.
Updated by NuriYuri (Youri Nouri) 3 months ago
Hi, I've read the box.md file as well as parts of the box.c file.
I'm also very interested into that project but as far as I understood it's not yet ready (some stuff are still to be done as well as some additional tests). I'm sure the rdoc will be added once Ruby::Box is completed.
On my side I believe it's wise to wait for 4.0 to be released because right now there's a lot of pressure on the other issues introduced by 4.0. In January it'll probably be a bit easier for the maintainer to deal with Box issues.
Updated by nobu (Nobuyoshi Nakada) 3 months ago
- Status changed from Open to Closed
Applied in changeset git|4a0e01d7681e72919f1fae7bc9db744e5a3fbe8c.
[Misc #21688] Teach RDoc about the toplevel module Ruby
Re-open the exising module by calling rb_define_module.
RDoc (RDoc::Parser::C#do_classes_and_modules) does not recognize
rb_path2class as a class/module definition.
Updated by zverok (Victor Shepelev) 3 months ago
- Status changed from Closed to Open
NB: Tentatively reopening this ticket, as it was autoclosed by the referring commit, but the ticket's scope is not only about the inclusion of Ruby::Box in the RDoc output.
Updated by nobu (Nobuyoshi Nakada) 3 months ago
zverok (Victor Shepelev) wrote:
- Should small(ish) problems/suggestions be reported? Can they be submitted as PRs? (I mean, things like "in some cases,
#inspectof the class in the Box is weird", and other stuff like this) Or this would be just distracting from the main work?
Any problems/suggestions/PRs will be welcome to report, of course.
The Box is no different than any other issue.
Updated by mame (Yusuke Endoh) 3 months ago
Can we close this?
Updated by zverok (Victor Shepelev) 3 months ago
- Status changed from Open to Closed