Bug #22597
closedRegexp named capture names with invalid source encoding
Description
Parse.y uses the resolved encoding of a regexp when introducing named captures. Prism uses the source encoding. This almost always works, but:
This results in a "あ" UTF-8 local that is invisible to user code unless accessed through binding.local_variable_get. This is such a niche unrealistic use case I didn't even really want to report it. But for the sake of simplicity, could we say it's alright to not introduce local variables through regexp named captures that cannot be represented in the source encoding?
Updated by nobu (Nobuyoshi Nakada) about 19 hours ago
- Backport changed from 3.3: UNKNOWN, 3.4: UNKNOWN, 4.0: UNKNOWN to 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED
Local variable definition by escaped form sounds insane.
Updated by nobu (Nobuyoshi Nakada) about 17 hours ago
- Status changed from Open to Closed
Applied in changeset git|441fc55bb1cbc616c59ee1b2b31dccd13ae2f8d9.
[Bug #22597] Reject incompatible encoding name variables
Regexp named capture names should be compatible with the source
encoding.
Updated by k0kubun (Takashi Kokubun) about 11 hours ago
- Backport changed from 3.3: REQUIRED, 3.4: REQUIRED, 4.0: REQUIRED to 3.3: REQUIRED, 3.4: REQUIRED, 4.0: DONE
ruby_4_0 89c2ca8b0f04198913251fe811aeda36337e6d5c merged revision(s) 441fc55bb1cbc616c59ee1b2b31dccd13ae2f8d9.