Bug #3391

Use single exclamation mark instead of double exclamation mark for IRB

Added by Diego Viola almost 5 years ago. Updated about 4 years ago.

[ruby-core:30589]
Status:Closed
Priority:Low
Assignee:Keiju Ishitsuka
ruby -v:Ruby 1.9.2-trunk Backport:

Description

=begin
Hello,

I'm adding this patch which changes the "!!" double exclamation marks in lib/irb.rb to use single exclamation marks "!", I think using single exclamation marks are more formal for outputs and Ruby itself.

The patch in question was patched from: http://github.com/ruby/ruby -- Please let me know if you want me to patch from SVN trunk instead.

Thanks and Best Regards,

Diego
=end

exclamation_mark_irb_fix.diff Magnifier (983 Bytes) Diego Viola, 06/05/2010 08:33 AM

History

#1 Updated by Nobuyoshi Nakada almost 5 years ago

  • Priority changed from Normal to Low
  • Target version set to 2.0.0
  • Status changed from Open to Assigned
  • Assignee set to Keiju Ishitsuka
  • Category set to lib

=begin

=end

#2 Updated by Diego Viola almost 5 years ago

=begin
When can I expect to see this merged?

Thanks,

Diego
=end

#3 Updated by Yukihiro Matsumoto almost 5 years ago

=begin
Hi,

In message "Re: [Bug #3391] Use single exclamation mark instead of double exclamation mark for IRB"
on Sat, 5 Jun 2010 08:33:07 +0900, Diego Viola redmine@ruby-lang.org writes:

|I'm adding this patch which changes the "!!" double exclamation marks in lib/irb.rb to use single exclamation marks "!", I think using single exclamation marks are more formal for outputs and Ruby itself.
|
|The patch in question was patched from: http://github.com/ruby/ruby -- Please let me know if you want me to patch from SVN trunk instead.

Although your claim is reasonable, we don't want to introduce any
incompatibility right now. So we will merge the patch on trunk, for
sometime in the future.

                        matz.

=end

#4 Updated by Yukihiro Matsumoto almost 5 years ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

=begin
This issue was solved with changeset r28363.
Diego, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

#5 Updated by Diego Viola almost 5 years ago

=begin
Thanks Matz, Ruby FTW.
=end

#6 Updated by Diego Viola almost 5 years ago

=begin
Why isn't this change included in Ruby 1.9.2 RC1?
=end

#7 Updated by Run Paint Run Run almost 5 years ago

=begin

Why isn't this change included in Ruby 1.9.2 RC1?

It was committed after the code freeze. See http://redmine.ruby-lang.org/wiki/ruby-19/ReleasePlan . :-)
=end

#8 Updated by Diego Viola almost 5 years ago

=begin
I see. Is there any chance it will be merged in future versions?

Thanks,

Diego
=end

#9 Updated by Run Paint Run Run almost 5 years ago

=begin
Certain. :-) It's been merged into trunk now, so the next release branched from trunk will have your patch applied. In addition, people who run bleeding-edge Ruby, i.e. build from trunk themselves, already have your patch. :-)
=end

#10 Updated by Diego Viola almost 5 years ago

=begin
Thanks
=end

Also available in: Atom PDF