Backport #4293: Errno::ENOMEM writing to STDOUT. Regression in 1.8.7-p330

• Status: Closed
• Assignee: shyouhei (Shyouhei Urabe)

[luislavena (Luis Lavena)]

=begin
Hello,

A user reported an issue with patchlevel 330 when writing long strings to STDOUT:

http://groups.google.com/group/rubyinstaller/browse_thread/thread/91bda7b5cfc488ae

This issue is not present in patchlevel 302.

The only reference I can find of this is Issue #1063 [ruby-core:21613], which affects Ruby 1.9.x, but not 1.8.x

The following are the changes introduced between both:

https://github.com/ruby/ruby/compare/v1_8_7_302...v1_8_7_330

Been of special interest the ones in win32/win32.c:

https://github.com/ruby/ruby/compare/v1_8_7_302...v1_8_7_330#diff-36

Besides that one, no other significant modification was introduced.

Could this be the root of the regression? Reverting the changes on init_stdhandle seems to solve the issue.

Thank you.
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned

=begin
Some additional info. That win32/win32.c change is commit 5ee39c26491e57a97f87896a7e1e76a5472157c1, which is in our SVN repo the revision 29862.

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29862

Which says the commit was to fix #3602. Usa-san, how do you feel?
=end

[usa (Usaku NAKAMURA)]

=begin
sorry, my mistake.
urabe-san, could you check r30604 of ruby_1_8 and backport it to ruby_1_8_7?
=end

[shyouhei (Shyouhei Urabe)]

• Assignee changed from nobu (Nobuyoshi Nakada) to shyouhei (Shyouhei Urabe)

=begin
I see. I'll check it.
=end

[luislavena (Luis Lavena)]

=begin
Hello Urabe-san,

Do you want me to handle the backport? I can also test if it worked or not.

Please let me know.

Thank you.
=end

[shyouhei (Shyouhei Urabe)]

=begin
No, please let me handle this.

But thank you.
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
This issue was solved with changeset r30902.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 30604:
* win32/win32.c (init_stdhandle): backport mistake of r29382.
some code are needless in ruby 1.8.
[ruby-core:34579]
=end