[PATCH] ext/fcntl/fcntl.c: add F_DUPFD_CLOEXEC constant
It's in POSIX.1-2008 and will be useful when Ruby becomes more
If/when 1291 goes through I'd also like IO#dup to work with the dup3()
system call, but this patch is much less intrusive.
#2 [ruby-core:37601] Updated by normalperson (Eric Wong) almost 7 years ago
Hiroshi Nakamura email@example.com wrote:
We're looking for a fcntl maintainer...
Since fcntl is related to I/O and files (and IO#fcntl is implemented in
io.c), why not just give this to io.c/file.c maintainers?
#3 [ruby-core:37624] Updated by kosaki (Motohiro KOSAKI) almost 7 years ago
- Status changed from Open to Assigned
- Assignee set to kosaki (Motohiro KOSAKI)
why not just give this to io.c/file.c maintainers?
We don't have io.c/file.c maintainers too. Anyway I assigned it to me. Please stop annoying ping pong.
#4 [ruby-core:37710] Updated by kosaki (Motohiro KOSAKI) almost 7 years ago
- Status changed from Assigned to Feedback
I've reviewed linux kernel source code and concluded this patch doesn't have the same issue with O_CLOEXEC when run on older kernels. So, I'll commit the patch if you make test case.
#5 [ruby-core:37713] Updated by normalperson (Eric Wong) almost 7 years ago
- File 0001-ext-fcntl-fcntl.c-add-F_DUPFD_CLOEXEC-constant.patch 0001-ext-fcntl-fcntl.c-add-F_DUPFD_CLOEXEC-constant.patch added
Also pushed to "fcntl-dupfd-cloexec" branch of git://bogomips.org/ruby.git