Bug #4619

io.c is broken on Windows

Added by Usaku NAKAMURA almost 3 years ago. Updated almost 3 years ago.

[ruby-dev:<unknown>]
Status:Closed
Priority:Immediate
Assignee:Nobuyoshi Nakada
Category:core
Target version:1.9.3
ruby -v:ruby 1.9.3dev (2011-04-27 trunk 31365) [x64-mswin64_100] Backport:

Description

=begin
r31355 以降、textmodeサポートがぶっ壊れてます。
(n)make testでテストが失敗しますし、test-allの方もEになりまくりです。
正直こんなもんrevertしろよって気分ですが、直せるあてはありますか?

make testの失敗:
#339 testliteral.rb: echo foo #=> "foo\r\n" (expected "foo\n")
#340 test
literal.rb: s = "foo"; echo #{s} #=> "foo\r\n" (expected "foo\n")

make test-allのEの抜粋:
Encoding::ConverterNotFoundError: code converter not found (universalnewline,crlfnewline)

=end


Related issues

Duplicates ruby-trunk - Bug #4618: Encoding::ConverterNotFoundErrors on trunk (Windows mingw) Closed 04/27/2011

Associated revisions

Revision 31367
Added by Nobuyoshi Nakada almost 3 years ago

  • io.c (rbioextractmodeenc, rbf_backquote): set default text mode. fixes #4619
  • io.c (pipe_open): set universal newline decorator if needed.

Revision 31377
Added by Nobuyoshi Nakada almost 3 years ago

  • io.c (make_writeconv): do not add textmode newline decorator if any newline decorator is set already. fixes #4618, fixes #4619

History

#1 Updated by Nobuyoshi Nakada almost 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r31367.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • io.c (rbioextractmodeenc, rbf_backquote): set default text mode. fixes #4619
  • io.c (pipe_open): set universal newline decorator if needed. =end

#2 Updated by Usaku NAKAMURA almost 3 years ago

  • Status changed from Closed to Assigned

=begin
test-allのエラーはまったく直ってないので、再オープンしときます。
現状、これに起因すると思われるエラーが私の手元では95個あります。
=end

#3 Updated by Nobuyoshi Nakada almost 3 years ago

  • Status changed from Assigned to Closed

=begin
This issue was solved with changeset r31377.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • io.c (make_writeconv): do not add textmode newline decorator if any newline decorator is set already. fixes #4618, fixes #4619 =end

Also available in: Atom PDF