Bug #4619: io.c is broken on Windows

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: 1.9.3
• ruby -v: ruby 1.9.3dev (2011-04-27 trunk 31365) [x64-mswin64_100]

[usa (Usaku NAKAMURA)]

=begin
r31355 以降、textmodeサポートがぶっ壊れてます。
(n)make testでテストが失敗しますし、test-allの方もEになりまくりです。
正直こんなもんrevertしろよって気分ですが、直せるあてはありますか?

make testの失敗:
#339 test_literal.rb: echo foo #=> "foo\r\n" (expected "foo\n")
#340 test_literal.rb: s = "foo"; echo #{s} #=> "foo\r\n" (expected "foo\n")

make test-allのEの抜粋:
Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)

=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
This issue was solved with changeset r31367.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• io.c (rb_io_extract_modeenc, rb_f_backquote): set default text
  mode. fixes #4619
• io.c (pipe_open): set universal newline decorator if needed.
  =end

[usa (Usaku NAKAMURA)]

• Status changed from Closed to Assigned

=begin
test-allのエラーはまったく直ってないので、再オープンしときます。
現状、これに起因すると思われるエラーが私の手元では95個あります。
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed

=begin
This issue was solved with changeset r31377.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• io.c (make_writeconv): do not add textmode newline decorator if any
  newline decorator is set already. fixes #4618, fixes #4619
  =end