Bug #5036

closed

time_modify/struct_modifyの例外メッセージがサブクラスの情報を反映しない

Added by ktsj (Kazuki Tsujimoto) almost 13 years ago. Updated almost 13 years ago.

Status:

Closed

Assignee:

ktsj (Kazuki Tsujimoto)

Target version:

ruby -v:

Backport:

[ruby-dev:44122]

Description

=begin
辻本です。

time_modify/struct_modifyにて生成される例外のメッセージに
クラス名がハードコーディングされているため、
これらがサブクラスのオブジェクトから呼ばれた場合でも
そのことが例外メッセージから読み取れません。

Timeの例:

class Time2 < Time
end
t = Time2.now
$SAFE=4
t.gmtime # => Insecure: can't modify Time (SecurityError)

Structの例:

class Struct2 < Struct
end
s = Struct2.new("S", :m).new
$SAFE=4
s.m=1 # => Insecure: can't modify Struct (SecurityError)

パッチを添付します。
=end

Files

fix-error-messages.patch (2.24 KB) fix-error-messages.patch

ktsj (Kazuki Tsujimoto), 07/17/2011 11:01 AM

Actions

Copy link

#1 [ruby-dev:44123]

Updated by nobu (Nobuyoshi Nakada) almost 13 years ago

Status changed from Open to Assigned
Assignee set to ktsj (Kazuki Tsujimoto)

入れちゃっていいんじゃないでしょうか。
あとはrb_check_frozen()のようにinsecureチェック用の関数を作るとか。

Actions

Copy link

#2 [ruby-dev:44124]

Updated by ktsj (Kazuki Tsujimoto) almost 13 years ago

コミット権を持っていないので、お手数ですがコミッタの方取り込みをお願いします。

Actions

Copy link

Updated by nobu (Nobuyoshi Nakada) almost 13 years ago

Status changed from Assigned to Closed
% Done changed from 0 to 100

This issue was solved with changeset r32569.
Kazuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

error.c (rb_check_trusted): new function to check an object is
trusted.
struct.c (rb_struct_modify), time.c (time_modify): check by the
above function to show proper class names. [Bug #5036]

Actions

Copy link

#4 [ruby-dev:44131]