Project

General

Profile

Bug #5140

Feature #5142: Remove ruby-mode.el from ruby's repo

Emacs ruby-mode major indentation bug with Ruby 1.9

Added by budu (Nicolas Buduroi) almost 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
nobu (Nobuyoshi Nakada)
Target version:
-
ruby -v:
HEAD
Backport:
[ruby-core:38684]

Description

When spreading the arguments of a method call on multiple lines using the new hash syntax from Ruby 1.9, the level of indentation is retained even after the closing parenthesis. Example:

belongs_to(:foo,
class_name: 'Foo',
foreign_key: 'foo_id')

      # the indentation level is wrong!

Files

ruby-keyword-symbols-patch.diff (2.18 KB) ruby-keyword-symbols-patch.diff rlipman (Reed Lipman), 04/21/2012 12:33 AM

Related issues

Related to Ruby master - Feature #6823: Where/how should ruby-mode issues be reported?ClosedActions

Associated revisions

Revision 983c2e87
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by nobu (Nobuyoshi Nakada) over 6 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

History

#1

Updated by naruse (Yui NARUSE) almost 8 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)
  • Parent task set to #5142
#2 [ruby-core:44491]

Updated by rlipman (Reed Lipman) over 7 years ago

This bug has been fixed in the base ruby-mode.el included in Emacs

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10786

I attached a copy of the patch if ruby-mode.el is still being maintained outside of GNU

#3

Updated by nobu (Nobuyoshi Nakada) over 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38150.
Nicolas, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Also available in: Atom PDF