Bug #5140

Feature #5142: Remove ruby-mode.el from ruby's repo

Emacs ruby-mode major indentation bug with Ruby 1.9

Added by Nicolas Buduroi almost 4 years ago. Updated over 2 years ago.

[ruby-core:38684]
Status:Closed
Priority:Normal
Assignee:Nobuyoshi Nakada
ruby -v:HEAD Backport:

Description

When spreading the arguments of a method call on multiple lines using the new hash syntax from Ruby 1.9, the level of indentation is retained even after the closing parenthesis. Example:

belongs_to(:foo,
class_name: 'Foo',
foreign_key: 'foo_id')

      # the indentation level is wrong!

ruby-keyword-symbols-patch.diff Magnifier (2.18 KB) Reed Lipman, 04/21/2012 12:33 AM


Related issues

Related to Ruby trunk - Feature #6823: Where/how should ruby-mode issues be reported? Assigned

Associated revisions

Revision 38150
Added by Nobuyoshi Nakada over 2 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Revision 38150
Added by Nobuyoshi Nakada over 2 years ago

ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

History

#1 Updated by Yui NARUSE almost 4 years ago

  • Status changed from Open to Assigned
  • Assignee set to Nobuyoshi Nakada
  • Parent task set to #5142

#2 Updated by Reed Lipman about 3 years ago

This bug has been fixed in the base ruby-mode.el included in Emacs

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10786

I attached a copy of the patch if ruby-mode.el is still being maintained outside of GNU

#3 Updated by Nobuyoshi Nakada over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38150.
Nicolas, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


ruby-mode.el: fix argument indent

  • misc/ruby-mode.el (ruby-block-end-re, ruby-delimiter) (ruby-mode-syntax-table, ruby-parse-partial, ruby-beginning-of-indent): merge from Emacs.
  • misc/ruby-mode.el (ruby-calculate-indent): fix indentation of argument lines in parentheses. [Bug #5140]

Also available in: Atom PDF