Bug #5164

Line endings, bug/regression or feature of 1.9.3?

Added by Luis Lavena over 2 years ago. Updated over 2 years ago.

[ruby-core:38822]
Status:Closed
Priority:High
Assignee:Nobuyoshi Nakada
Category:core
Target version:1.9.3
ruby -v:- Backport:

Description

Hello,

Seems Redmine is down, so emailing the list.

One user detected that Ruby 1.9.3-preview1 and latest changes in
ruby19_3 branch generates incorrectly line endings on Windows.

It seems that now, by default, it uses LF instead of CRLF for writing,
unless you explicitly indicate text-mode ('t')

Full investigation of the user is found here:

http://groups.google.com/group/rubyinstaller/msg/65cd1284e10ffe71

And simple test:

V:>ruby -ve "n

Associated revisions

Revision 33165
Added by Nobuyoshi Nakada over 2 years ago

  • io.c (validateencbinmode, prep_stdio): default to text mode on dosish platforms. [Bug #5164]
  • transcode.c (rbeconvprepare_options): keep default ecflags unchanged if no options.

History

#1 Updated by Nobuyoshi Nakada over 2 years ago

  • Category set to core
  • Status changed from Open to Assigned
  • Assignee set to Nobuyoshi Nakada
  • Priority changed from Normal to High
  • Target version set to 1.9.3

#2 Updated by Luis Lavena over 2 years ago

Hello Mr. Nakada, any word on this?

Thank you.

#3 Updated by Motohiro KOSAKI over 2 years ago

Ping?

#4 Updated by Luis Lavena over 2 years ago

Mr Nakada,

I can take care of this if time is an issue for you. I just need your approval/confirmation from you.

Please let us know so another 1.9.3 release goes out with this broken behavior.

Thank you.

#5 Updated by Motohiro KOSAKI over 2 years ago

Mr Nakada,

I can take care of this if time is an issue for you. I just need your approval/confirmation from you.
Please let us know so another 1.9.3 release goes out with this broken behavior.

Nakada-san,

I think this issue should be fixed before 1.9.3 release. I hope 1.9.3
has no regression.

#6 Updated by Nobuyoshi Nakada over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33165.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • io.c (validateencbinmode, prep_stdio): default to text mode on dosish platforms. [Bug #5164]
  • transcode.c (rbeconvprepare_options): keep default ecflags unchanged if no options.

#7 Updated by Luis Lavena over 2 years ago

Thank you Nakada-san, works perfectly!

Also available in: Atom PDF