Project

General

Profile

Actions

Bug #5251

closed

Thread Change Breaks Windows Builds

Added by cfis (Charlie Savage) over 12 years ago. Updated over 12 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 1.9.3dev (2011-08-26 revision 33077) [i386-mingw32]
Backport:
[ruby-core:39195]

Description

This commit:

Commit:4e9438bc9153f7a1f4ea0af85c8dbe359e1a55d8

Causes this error:

thread.c: In function rb_thread_select': thread.c:2685: warning: missing braces around initializer thread.c:2685: warning: (near initialization for fdsets[0]')
thread.c:2693: error: implicit declaration of function `rb_fd_copy'
make: *** [thread.o] Error 1

Using mingw, with this gcc:

gcc version 3.4.5 (mingw-vista special r3)

Note that in thread.c, rb_fd_copy is not defined for win32, and therefore, this breaks. Thus, this would break for msvc also it looks.


Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #5229: [PATCH] thread.c (rb_thread_select): implement using rb_thread_fd_selectClosedkosaki (Motohiro KOSAKI)08/25/2011Actions
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0