Backport #5311
closed
PStore fails to save data when default encodings are set
Added by camerooni (Cameron Pope) over 12 years ago.
Updated over 12 years ago.
Description
When PStore opens its data files, it does so using the File::BINARY flag, which ensures that Windows will not do cr-lf conversions, but it does not ensure that file#external_encoding is ASCII_8BIT (Binary). That means that under certain circumstances (when Encoding.internal_encoding is defined) that PStore will sometimes raise errors when writing to disk because Marshal.dump will emit a byte sequence that is not valid with the file's external encoding.
To illustrate, I've submitted a patch that contains a test that fails in Ruby 1.9.x, but passes with the minor change to PStore: to specify external_encoding when opening its data files.
Files
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r33264.
Cameron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- lib/pstore.rb (PStore): always open in binary mode even if
default encodings are set. [Bug #5311] [ruby-core:39503]
- Tracker changed from Bug to Backport
- Project changed from Ruby master to Backport193
- Status changed from Closed to Assigned
- Assignee set to yugui (Yuki Sonoda)
- Target version deleted (
2.0.0)
this seems no regression.
- Status changed from Assigned to Closed
This issue was solved with changeset r33440.
Cameron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
merges r33264 from trunk into ruby_1_9_3.¶
- lib/pstore.rb (PStore): always open in binary mode even if
default encodings are set. [Bug #5311] [ruby-core:39503]
Also available in: Atom
PDF
Like0
Like0Like0Like0Like0