Project

General

Profile

This project is closed and read-only.

Actions
Copy link

Backport #5331

closed

Ripper#yydebug and friends don't work

Backport #5331: Ripper#yydebug and friends don't work

Added by drbrain (Eric Hodel) about 15 years ago. Updated almost 15 years ago.

Status:
Closed
Assignee:
yugui (Yuki Sonoda)
[ruby-core:39591]

Description

Ripper#yydebug, #yydebug=, #end_seen? and #encoding all fail to work with a TypeError due to using a different parser_data_type.

The attached patch fixes this by defining static implementations:

ripper_end_seen_p
ripper_encoding
ripper_get_yydebug
ripper_set_yydebug

I don't know if it's the right patch, though. I tried making parser_data_type an exported symbol but had no luck.

The attached test file adds tests for each of these methods to ensure they work.

PS: redmine is down

Files

Download all files
parser.y.ripper_yydebug.patch (3.54 KB) parser.y.ripper_yydebug.patch drbrain (Eric Hodel), 09/17/2011 02:52 PM
test_ripper.rb (800 Bytes) test_ripper.rb drbrain (Eric Hodel), 09/17/2011 02:52 PM

Updated by drbrain (Eric Hodel) about 15 years ago Actions
Copy link
 #1 [ruby-core:39603]

  • Category set to ext
  • Target version set to 1.9.4
  • ruby -v changed from - to ruby 1.9.4dev (2011-09-15 trunk 33272) [x86_64-darwin11.1.0]

Updated by nobu (Nobuyoshi Nakada) about 15 years ago Actions
Copy link
 #2

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33291.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • parse.y (parser_data_type): inherit the core type in ripper so
    that checks in core would work. [ruby-core:39591] [Bug #5331]

Updated by nobu (Nobuyoshi Nakada) about 15 years ago Actions
Copy link
 #3

  • Tracker changed from Bug to Backport
  • Project changed from Ruby to 13
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee set to yugui (Yuki Sonoda)
  • Target version deleted (1.9.4)

Updated by yugui (Yuki Sonoda) almost 15 years ago Actions
Copy link
 #4

  • Status changed from Assigned to Closed

This issue was solved with changeset r33321.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

merges r33291 from trunk into ruby_1_9_3.

  • parse.y (parser_data_type): inherit the core type in ripper so
    that checks in core would work. [ruby-core:39591] [Bug #5331]
Actions
Copy link

Also available in: PDF Atom