Bug #5425: Improves Array's uniq/uniq! example

• Status: Closed
• Assignee: drbrain (Eric Hodel)
• Target version: 1.9.3
• ruby -v: trunk

[alvaropereyra (Alvaro Pereyra Rabanal)]

Updates examples on uniq and uniq! with a more cleaner case. Changes wording to refer a block is possible.

[Eregon (Benoit Daloze)]

There is a typo in the example for uniq:
b.uniq!{ ...

Also, the added description how to pass a block should be the same in uniq and uniq! (I prefer the one of uniq!).

Thanks for documenting in sentences this behavior.

[alvaropereyra (Alvaro Pereyra Rabanal)]

• File 0001-Improves-array-content-for-some-methods-and-examples.patch 0001-Improves-array-content-for-some-methods-and-examples.patch added

Thanks Benoit. I've fixed that typo and used the same explanation for both uniq and uniq!. Also made some other changes to other sections on the Array.

[drbrain (Eric Hodel)]

Please watch for trailing whitespace in your patches.

[drbrain (Eric Hodel)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r33453.
Alvaro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• array.c (rb_ary_initialize): Improve explanation of Array.new
  parameters. Patch by Alvaro Pereyra Rabanal. [Ruby 1.9 - Bug #5425]
• array.c (rb_ary_s_try_convert): Fix typo (try => tries)
• array.c (rb_ary_rindex): Add spacing for block.
• array.c (rb_ary_uniq_bang): Describe block
• array.c (rb_ary_uniq): ditto

[alvaropereyra (Alvaro Pereyra Rabanal)]

Eric Hodel wrote:

Please watch for trailing whitespace in your patches.

Will do. Sorry for that. The idea is to ease your work, not burden it :P.