Bug #5563

Fix bug in drb tests if hostname does not resolve to a local IP

Added by Jeremy Evans over 2 years ago. Updated 9 months ago.

[ruby-core:40713]
Status:Closed
Priority:Normal
Assignee:Masatoshi Seki
Category:test
Target version:-
ruby -v:ruby 1.9.3p0 (2011-10-30 revision 33570) [i386-openbsd] Backport:

Description

3 of the drb tests leave the hostname part of the druby URI empty instead of using localhost. When a hostname is not provided, ruby uses the system hostname, which usually resolves to a local IP address, but not always. This causes the tests to fail if the system hostname doesn't resolve to a local IP address. The tests also appear to hang, since the connection timeout is 100 seconds.

The attached patch fixes this case by using localhost as the hostname in the 3 tests that did not already do that, making them consistent with the other tests.

test_drb_localhost.diff Magnifier (1.24 KB) Jeremy Evans, 11/04/2011 01:57 AM

History

#1 Updated by Koichi Sasada about 2 years ago

  • Assignee set to Masatoshi Seki

#2 Updated by Shyouhei Urabe about 2 years ago

  • Status changed from Open to Assigned

#3 Updated by Jeremy Evans 9 months ago

This bug can be closed. Bug #7311 was a duplicate of this bug with the exact same patch I provided, and the patch was applied at r41916.

#4 Updated by Zachary Scott 9 months ago

  • Status changed from Assigned to Closed

Thanks Jeremy!

Also available in: Atom PDF