Bug #5752
Array#delete_if side effects due to changeset r32360
Description
It seems that the changeset r32360 introduced another side effect. Here are two IRB sessions, one in ruby-1.9.2-p136 and the other in ruby-1.9.3-p0:
ruby-1.9.2-p136 :001 > x = [1,2,3,4,5,6,7,8,9]
=> [1, 2, 3, 4, 5, 6, 7, 8, 9]
ruby-1.9.2-p136 :002 > x.delete_if {|i| i == x[i-1]}
=> []
ruby-1.9.3-p0 :001 > x = [1,2,3,4,5,6,7,8,9]
=> [1, 2, 3, 4, 5, 6, 7, 8, 9]
ruby-1.9.3-p0 :002 > x.delete_if {|i| i == x[i-1]}
=> [2, 3, 4, 5, 6, 7, 8, 9]
If this is indeed the intended behaviour, it should probably be documented clearly that the array is changed instantly every time the block is called and not after the iteration is over.
Related issues
Associated revisions
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
- array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc. documentation from Thomas Leitner in . [Bug #5752]
History
#1
[ruby-core:41646]
Updated by funny_falcon (Yura Sokolov) over 6 years ago
Updated by Actually, it were next changeset r32373
#2
[ruby-core:41647]
Updated by funny_falcon (Yura Sokolov) over 6 years ago
- File array.c.patch array.c.patch added
#3
[ruby-core:41664]
Updated by nobu (Nobuyoshi Nakada) over 6 years ago
Updated by - Category changed from core to doc
- Status changed from Open to Closed
#4
[ruby-core:67483]
Updated by akr (Akira Tanaka) over 3 years ago
Updated by - Related to Feature #10714: Array#reject! nonlinear performance problem added
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e