Backport #5753

[Ripper] on_magic_comment doesn't pass proper value

Added by Nobuyoshi Nakada over 2 years ago. Updated about 1 year ago.

[ruby-dev:44984]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

=begin
$ ruby -v -rripper -e 'r = Ripper.new("# -- foo: bar --"); def r.onmagiccomment(*x);p x;end;r.parse'
["foo", false]

Should be ((%["foo", "bar"]%)).

Affects also 1.9.
=end

Associated revisions

Revision 40228
Added by Usaku NAKAMURA about 1 year ago

merge revision(s) 34022: [Backport #5753]

* parse.y (parser_magic_comment): should pass the proper value.
  [Bug #5753]

History

#1 Updated by Nobuyoshi Nakada over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34022.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • parse.y (parsermagiccomment): should pass the proper value. [Bug #5753]

#2 Updated by Nobuyoshi Nakada over 2 years ago

  • Tracker changed from Bug to Backport
  • Project changed from ruby-trunk to Backport93
  • Category deleted (ext)
  • Target version deleted (2.0.0)

#3 Updated by Nobuyoshi Nakada about 1 year ago

  • Status changed from Closed to Assigned
  • Assignee changed from Nobuyoshi Nakada to Usaku NAKAMURA

#4 Updated by Usaku NAKAMURA about 1 year ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40228.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 34022: [Backport #5753]

* parse.y (parser_magic_comment): should pass the proper value.
  [Bug #5753]

Also available in: Atom PDF