Project

General

Profile

This project is closed and read-only.

Actions
Copy link

Backport #5753

closed

[Ripper] on_magic_comment doesn't pass proper value

Backport #5753: [Ripper] on_magic_comment doesn't pass proper value

Added by nobu (Nobuyoshi Nakada) almost 15 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
usa (Usaku NAKAMURA)
[ruby-dev:44984]

Description

=begin
$ ruby -v -rripper -e 'r = Ripper.new("# -- foo: bar --"); def r.on_magic_comment(*x);p x;end;r.parse'
["foo", false]

Should be ((%["foo", "bar"]%)).

Affects also 1.9.
=end

Updated by nobu (Nobuyoshi Nakada) almost 15 years ago Actions
Copy link
 #1

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34022.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • parse.y (parser_magic_comment): should pass the proper value.
    [ruby-dev:44984][Bug #5753]

Updated by nobu (Nobuyoshi Nakada) almost 15 years ago Actions
Copy link
 #2

  • Tracker changed from Bug to Backport
  • Project changed from Ruby to 13
  • Category deleted (ext)
  • Target version deleted (2.0.0)

Updated by nobu (Nobuyoshi Nakada) over 13 years ago Actions
Copy link
 #3 [ruby-dev:47228]

  • Status changed from Closed to Assigned
  • Assignee changed from nobu (Nobuyoshi Nakada) to usa (Usaku NAKAMURA)

Updated by usa (Usaku NAKAMURA) over 13 years ago Actions
Copy link
 #4

  • Status changed from Assigned to Closed

This issue was solved with changeset r40228.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

merge revision(s) 34022: [Backport #5753]

* parse.y (parser_magic_comment): should pass the proper value.
  [ruby-dev:44984][Bug #5753]
Actions
Copy link

Also available in: PDF Atom