Improve socket exception message when bind() fails
If the user tries to bind a port that is already in use the user does not receive any notification of which port (and address) failed. When multiple connections are being made makes it difficult to determine which connection was not correctly bound.
For example, WEBrick binds both IPv4 and IPv6 sockets. If one of the ports is already bound you will receive a confusing error message.
This patch adds the port and address to the error message:
$ cat test.rb
TCPServer.new '0.0.0.0', 5900
$ make runruby
./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems ./test.rb
initialize': Address already in use - bind(2) for "0.0.0.0" port 5900 (Errno::EADDRINUSE)new'
from ./test.rb:3:in `'
make: *** [runruby] Error 1
$ ruby test.rb
initialize': Address already in use - bind(2) (Errno::EADDRINUSE)new'
from test.rb:3:in `'
Updated by drbrain (Eric Hodel) about 8 years ago
This updated patch adds three new methods rsock_sys_fail_host_port, rsock_sys_fail_path and rsock_sys_fail_sockaddr for raising exceptions from more than bind().
Additionally, rb_sys_fail() calls were audited and names of system calls were added where they were missing, and updated where incomplete (lacking manual page designator).
Updated by akr (Akira Tanaka) over 7 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r40149.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
ext/socket: Improve socket exception message to show socket address.
[ruby-core:45617] [Feature #6583] proposed Eric Hodel.
ext/socket/rubysocket.h (rsock_sys_fail_host_port): Declared.
ext/socket/udpsocket.c (udp_connect): Use rsock_sys_fail_host_port.
ext/socket/init.c (rsock_init_sock): Specify a string for rb_sys_fail
ext/socket/ipsocket.c (init_inetsock_internal): Use
ext/socket/socket.c (rsock_sys_fail_host_port): Defined.
(setup_domain_and_type): Use rsock_sys_fail_sockaddr.
(sock_gethostname): Specify a string for rb_sys_fail argument.
ext/socket/basicsocket.c (bsock_shutdown): Specify a string for
(bsock_setsockopt): Use rsock_sys_fail_path.
(bsock_getpeereid): Refine the argument for rb_sys_fail.
ext/socket/unixsocket.c (rsock_init_unixsock): Use