Bug #6610

Fix Benchmark.benchmark output with an empty caption

Added by Benoit Daloze almost 3 years ago. Updated almost 3 years ago.

[ruby-core:45719]
Status:Closed
Priority:Normal
Assignee:Yui NARUSE
ruby -v:ruby 2.0.0dev (2012-05-25 trunk 35779) [x86_64-darwin10.8.0] Backport:

Description

Hello,

I noticed Benchmark.benchmark output with an empty caption has an extra space.
This is due to my change in r32269, so I am sorry, this is my fault.
I guess Benchmark.benchmark is not much used directly
and without caption though (and nobody reported this issue).

It also includes a fix to avoid defining constants at the top-level
(this was due to class_eval with a block) and a few other small fixes.

You can see the commits on my benchmark branch: https://github.com/eregon/ruby/compare/e3761441...benchmark
(Or https://github.com/eregon/ruby/compare/trunk...benchmark, after the last Merge commit)

Please let me know what I can do to help committing these changes.

Associated revisions

Revision 36427
Added by Yui NARUSE almost 3 years ago

  • lib/benchmark.rb: Fix Benchmark.benchmark output with an empty caption. patched by Benoit Daloze. [Bug #6610]

Revision 36427
Added by Yui NARUSE almost 3 years ago

  • lib/benchmark.rb: Fix Benchmark.benchmark output with an empty caption. patched by Benoit Daloze. [Bug #6610]

History

#1 Updated by Yusuke Endoh almost 3 years ago

  • Status changed from Open to Assigned

#2 Updated by Yui NARUSE almost 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36427.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/benchmark.rb: Fix Benchmark.benchmark output with an empty caption. patched by Benoit Daloze. [Bug #6610]

Also available in: Atom PDF