Bug #6625

broken Marshal compatibilities on Complex and Rational

Added by Nobuyoshi Nakada almost 3 years ago. Updated over 2 years ago.

[ruby-core:45775]
Status:Closed
Priority:Low
Assignee:tadayoshi funaba
ruby -v:2.0.0 Backport:

Description

=begin
(({Complex})) and (({Rational})) dumped by 1.8 or earlier cannot be loaded by trunk.

$ /usr/bin/ruby -v
ruby 1.8.7 (2011-12-28 patchlevel 357) [universal-darwin11.0]

$ ruby -v
ruby 2.0.0dev (2012-06-22 trunk 36175) [universal.x86_64-darwin11]

$ /usr/bin/ruby -rcomplex -e 'Marshal.dump(Complex(0, 0), STDOUT)' | ruby -e 'p Marshal.load(STDIN)'
-e:1:in load': dump format error (ArgumentError)
from -e:1:in
'
bash: exit 1

$ /usr/bin/ruby -rrational -e 'Marshal.dump(Rational(0), STDOUT)' | ruby -e 'p Marshal.load(STDIN)'
-e:1:in load': dump format error (ArgumentError)
from -e:1:in
'
bash: exit 1

Patch attached.
=end

0001-compatible-marshal-loader.patch Magnifier (5.6 KB) Nobuyoshi Nakada, 06/22/2012 02:08 PM

Associated revisions

Revision 36538
Added by Nobuyoshi Nakada over 2 years ago

complex.c, rational.c: compatible marshal loader

  • complex.c, rational.c: compatible marshal loader for compatibilities with 1.8. [Bug #6625]

Revision 36538
Added by Nobuyoshi Nakada over 2 years ago

complex.c, rational.c: compatible marshal loader

  • complex.c, rational.c: compatible marshal loader for compatibilities with 1.8. [Bug #6625]

History

#1 Updated by tadayoshi funaba almost 3 years ago

  • Priority changed from Normal to Low

should we still support 1.8 dump?

#2 Updated by Shyouhei Urabe almost 3 years ago

tadf (tadayoshi funaba) wrote:

should we still support 1.8 dump?

Yes please. We no longer need to write old formats, but I still need to read. Otherwise I cannot convert them into new formats.

#3 Updated by tadayoshi funaba almost 3 years ago

ok, support forever.

#4 Updated by Nobuyoshi Nakada over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36538.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


complex.c, rational.c: compatible marshal loader

  • complex.c, rational.c: compatible marshal loader for compatibilities with 1.8. [Bug #6625]

Also available in: Atom PDF