Bug #6742

Emacs compilation-shell-minor-mode misconfiguration

Added by Jean-Christophe Petkovich almost 2 years ago. Updated over 1 year ago.

[ruby-core:46518]
Status:Closed
Priority:Normal
Assignee:Nobuyoshi Nakada
Category:misc
Target version:-
ruby -v:ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux] Backport:

Description

In the definition of inferior-ruby-mode, compilation-shell-minor-mode is enabled before it's variables are set. The way compilation shell is written, this will cause very strange highlighting in the inferior buffer, and inconsistent and useless behaviour of next-error. A simple fix is to put the enable after the setting of those variables. After that, next-error should take you to the file/linenumber of errors listed in the inferior buffer!

Patch which fixes the issue on my box is included.

inf-ruby.patch Magnifier - Patch to fix the compilation-shell-minor-mode configuration (614 Bytes) Jean-Christophe Petkovich, 07/17/2012 02:48 AM


Related issues

Related to ruby-trunk - Feature #6823: Where/how should ruby-mode issues be reported? Assigned

Associated revisions

Revision 38107
Added by Nobuyoshi Nakada over 1 year ago

inf-ruby.el: fix compilation-shell-minor-mode

  • misc/inf-ruby.el (inferior-ruby-mode): fix the compilation-shell-minor-mode configuration. a patch by j2petkov (Jean-Christophe Petkovich) in . [Bug #6742]

History

#1 Updated by Jean-Christophe Petkovich almost 2 years ago

Somehow I managed to avoid including the patch file. Let's try that again.

#2 Updated by Yusuke Endoh over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to Nobuyoshi Nakada

Nobu, please check this.

Yusuke Endoh mame@tsg.ne.jp

#3 Updated by Nobuyoshi Nakada over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38107.
Jean-Christophe, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


inf-ruby.el: fix compilation-shell-minor-mode

  • misc/inf-ruby.el (inferior-ruby-mode): fix the compilation-shell-minor-mode configuration. a patch by j2petkov (Jean-Christophe Petkovich) in . [Bug #6742]

Also available in: Atom PDF