Bug #7027

Tempfile#inspect is Confusing

Added by Masaki Matsushita over 1 year ago. Updated over 1 year ago.

[ruby-core:47544]
Status:Closed
Priority:Normal
Assignee:Masaki Matsushita
Category:lib
Target version:2.0.0
ruby -v:ruby 2.0.0dev (2012-09-15 trunk 36975) [x86_64-linux] Backport:

Description

I think Tempfile#inspect is really confusing.
It says Tempfile object is a File, but it is not a File object.

% irb -r tempfile
irb(main):001:0> t = Tempfile.new("hoge")
=> #File:/tmp/hoge20120916-12354-uontdm
irb(main):002:0> t.is_a? File
=> false
irb(main):003:0>

see also (Japanese): http://r7kamura.hatenablog.com/entry/2012/09/05/194630

patch.diff Magnifier (337 Bytes) Masaki Matsushita, 09/16/2012 12:18 AM

History

#1 Updated by Hans Mackowiak over 1 year ago

in my opinion Delegator should be improved
so it shows that its a Tempfile, but is_a? should also show that its a File or IO

#2 Updated by Charles Nutter over 1 year ago

In my opinion, Tempfile should not use Delegator at all.

In JRuby, Tempfile actually is a File.

irb(main):001:0> require 'tempfile'
=> true
irb(main):002:0> t = Tempfile.new('blah')
=> #Tempfile:/var/folders/9j/yc18czps1x7cbsz76ccl__740000gn/T/blah.77744.52665
irb(main):003:0> t.class
=> Tempfile
irb(main):004:0> t.class.superclass
=> File
irb(main):005:0> t.is_a? File
=> true
irb(main):006:0> Tempfile.ancestors
=> [Tempfile, File, IO, File::Constants, Enumerable, Object, Kernel, BasicObject]

#3 Updated by Yusuke Endoh over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to Masaki Matsushita
  • Target version set to 2.0.0

Glass_saga,

Sounds good. Please commit it.
If something comes up, we can deal with it then.

Yusuke Endoh mame@tsg.ne.jp

#4 Updated by Masaki Matsushita over 1 year ago

  • Status changed from Assigned to Closed

I have commited in r37492.

#5 Updated by Tomoyuki Chikanaga over 1 year ago

  • r37493 (for ChangeLog ML, ticket ref.)

Also available in: Atom PDF