Project

General

Profile

Actions

Bug #7036

closed

Compiling extensions with Ruby in a path with spaces

Added by luislavena (Luis Lavena) almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 2.0.0dev (2012-09-16 trunk 36983) [i386-mingw32]
Backport:
[ruby-core:47565]

Description

=begin
Hello,

This has been reported several times to RubyInstaller: inability to install gems when Ruby has been installed in a path with spaces (e.g. (({C:\Program Files})))

Since this is presented to the user as (({gem install})) error, a deeper investigation revealed:

Generated Makefile contains a reference to (({RUBY})) that is not quoted, resulting in errors like this:

V:\User Name\ruby-2.0.0dev-i386-mingw32\lib\ruby\gems\2.0.0\gems\json-1.7.5\ext\json\ext\generator>make
generating generator-i386-mingw32.def
/bin/sh: V:/User: No such file or directory
make: *** [generator-i386-mingw32.def] Error 127

This can be easily solved by doing:

ruby = #{$ruby.quote}

The second issue is more complicated, as is caused by (({$LIBPATH})) and (({libdir})):

linking shared-object json/ext/generator.so
gcc.exe: error: Name/ruby-2.0.0dev-i386-mingw32/lib: No such file or directory
make: *** [generator.so] Error 1

While (({LIBPATH})) is being built using (({libpathflag})) method, this method fails to detect path with spaces since it uses (({LIBPATHFLAG})) from rbconfig

Since mkmf finds the above mentioned key in (({RbConfig::CONFIG})), it never attempts to use -L"%s" alternative:

LIBPATHFLAG = config_string('LIBPATHFLAG') || ' -L"%s"'

Now, (({libpathflag})) do not detect a path with spaces because the array of options given are (({[".", "$(libdir)"]})).

In the case of Windows, LIBPATHFLAG shouldn't be hardcoded, or at least should always quote strings, considering Ruby can be relocated.

Nobu, Usa, Hiroshi, what are your thoughts about this?

I'm looking for some feedback before I start some modifications.

Thank you in advance for your time.
=end


Files

disable-libpathflag-mingw.diff (473 Bytes) disable-libpathflag-mingw.diff luislavena (Luis Lavena), 09/18/2012 11:04 PM
disable-libpathflag-mingw.v2.diff (871 Bytes) disable-libpathflag-mingw.v2.diff luislavena (Luis Lavena), 09/20/2012 03:26 PM

Related issues 1 (0 open1 closed)

Is duplicate of Ruby master - Bug #3024: mkmf: Directory names with spaces cause invalid Makefiles to be generatedClosednobu (Nobuyoshi Nakada)03/27/2010Actions
Actions

Also available in: Atom PDF