Bug #7380

benchmark/driver.rb: --executables separator

Added by Benoit Daloze over 1 year ago. Updated over 1 year ago.

[ruby-core:49488]
Status:Closed
Priority:Normal
Assignee:Koichi Sasada
Category:-
Target version:2.0.0
ruby -v:ruby 2.0.0dev (2012-11-17 trunk 37693) [x86_64-darwin10.8.0] Backport:

Description

Hello,

The separator used between ruby executables for the benchmark/driver.rb script is ";".
This requires the argument to be quoted (at least in bash/zsh) and produce an unintuitive result if not: only the first executable is taken by the script, the second executable launches the ruby interpreter with no arguments, thus waiting on stdin, which feels like the benchmark script hangs.

I proposed to use ":", the standard path separator instead.
For compatibility, ";" could split too, but I wish to document ":" in the help.

What do you think? May I go ahead?

Associated revisions

Revision 37854
Added by Koichi Sasada over 1 year ago

  • benchmark/driver.rb: accept multiple -e'. You don't need to use;' separation character. [ruby-trunk - Bug #7380]

History

#1 Updated by Yusuke Endoh over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to Koichi Sasada
  • Target version set to 2.0.0

ko1, what do you think?

Yusuke Endoh mame@tsg.ne.jp

#2 Updated by Koichi Sasada over 1 year ago

I always use -e with quote strings. does it bother you?

By the way, -e accept `:'
like -e "foo::path1; bar::path2"
as a label of path.

#3 Updated by Koichi Sasada over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37854.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • benchmark/driver.rb: accept multiple -e'. You don't need to use;' separation character. [ruby-trunk - Bug #7380]

#4 Updated by Benoit Daloze over 1 year ago

ko1 (Koichi Sasada) wrote:

I always use -e with quote strings. does it bother you?

By the way, -e accept `:'
like -e "foo::path1; bar::path2"
as a label of path.

Oh, right, I did not think to the name::path usage, it would be weird to have both : and ::.

I like the solution to pass multiple -e options, thank you!

Also available in: Atom PDF