Project

General

Profile

Actions

Feature #7387

closed

Keep LOADED_FEATURES sorted by filename without extention for faster lookup on require.

Added by zzak (zzak _) almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Target version:
[ruby-core:49535]

Description

I'm moving this over from github:
https://github.com/ruby/ruby/pull/66


Files


Related issues 1 (0 open1 closed)

Is duplicate of Ruby master - Feature #5427: Not complex patch to improve `require` time (load.c)Closednobu (Nobuyoshi Nakada)10/09/2011Actions

Updated by mame (Yusuke Endoh) almost 12 years ago

  • Status changed from Open to Feedback
  • Assignee changed from mame (Yusuke Endoh) to zzak (zzak _)

Zachary, thank you for the sorting out the tickets!

I think that the problem itself was fixed effectively by #7158.
Am I misunderstanding?

--
Yusuke Endoh

Updated by zzak (zzak _) almost 12 years ago

mame, you're welcome, I hope it helps you with the release!

I wasn't sure if this was included in #7158, so it may be duplicate. Feel free to close this ticket.

Updated by zzak (zzak _) almost 12 years ago

  • Assignee changed from zzak (zzak _) to h.shirosaki (Hiroshi Shirosaki)

Hiroshi-san can you verify this has been resolved?

Updated by h.shirosaki (Hiroshi Shirosaki) almost 12 years ago

  • Status changed from Feedback to Closed

LOADED_FEATURES hash index was included in #7158. Sorted LOADED_FEATURES is another approach for faster LOADED_FEATURES lookup in require, but we cannot apply both of them since they are conflicted implementations. Performance issue of require was fixed by #7158. So I close this.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0