Feature #7387

Keep LOADED_FEATURES sorted by filename without extention for faster lookup on require.

Added by Zachary Scott over 1 year ago. Updated over 1 year ago.

[ruby-core:49535]
Status:Closed
Priority:Normal
Assignee:Hiroshi Shirosaki
Category:core
Target version:2.0.0

Description

I'm moving this over from github:
https://github.com/ruby/ruby/pull/66

sort_loaded_features_by_filename_without_extension.patch Magnifier (11.5 KB) Zachary Scott, 11/19/2012 07:32 AM


Related issues

Duplicates ruby-trunk - Feature #5427: Not complex patch to improve `require` time (load.c) Closed 10/09/2011

History

#1 Updated by Yusuke Endoh over 1 year ago

  • Status changed from Open to Feedback
  • Assignee changed from Yusuke Endoh to Zachary Scott

Zachary, thank you for the sorting out the tickets!

I think that the problem itself was fixed effectively by #7158.
Am I misunderstanding?

Yusuke Endoh mame@tsg.ne.jp

#2 Updated by Zachary Scott over 1 year ago

mame, you're welcome, I hope it helps you with the release!

I wasn't sure if this was included in #7158, so it may be duplicate. Feel free to close this ticket.

#3 Updated by Zachary Scott over 1 year ago

  • Assignee changed from Zachary Scott to Hiroshi Shirosaki

Hiroshi-san can you verify this has been resolved?

#4 Updated by Hiroshi Shirosaki over 1 year ago

  • Status changed from Feedback to Closed

LOADEDFEATURES hash index was included in #7158. Sorted LOADEDFEATURES is another approach for faster LOADED_FEATURES lookup in require, but we cannot apply both of them since they are conflicted implementations. Performance issue of require was fixed by #7158. So I close this.

Also available in: Atom PDF